fail2ban, setools: use python3-setuptools for pkg_resources#29043
Conversation
ghost
force-pushed
the
python/fix-missing-dependencies
branch
from
5e1f71d to
8d718f1
Compare
Member
While looking at it, I see that onionshare_cli the latest version is 2.6.3 while we do have 2.3.1, looks like it is not maintained well in our repository. |
python3-pkg-resources does not exist as a separate OpenWrt package; pkg_resources ships inside python3-setuptools. Signed-off-by: Joshua Klinesmith <joshuaklinesmith@gmail.com>
python3-pkg-resources does not exist as a separate OpenWrt package; pkg_resources ships inside python3-setuptools. Also add missing libpython3 runtime dependency. Signed-off-by: Joshua Klinesmith <joshuaklinesmith@gmail.com>
ghost
force-pushed
the
python/fix-missing-dependencies
branch
from
8d718f1 to
22e5e3e
Compare
ghost
changed the title
Author
|
@BKPepe Thanks, I was aware those packages had been removed but wasn't sure how to handle onionshare-cli's broken dependencies, adding them back was the wrong call. I've rebased the PR to drop the python-pysocks and python-unidecode commits. It now only contains the fail2ban and setools fixes (python3-pkg-resources → python3-setuptools), which stand on their own. As for onionshare-cli, it's sitting at 2.3.1 while upstream is at 2.6.3, and even the latest version still requires both pysocks and unidecode. Happy to look into updating or removing it in a separate PR if that would be helpful. |
ghost
closed this by deleting the head repository
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python3-pkg-resourcesruntime dependency withpython3-setuptools(wherepkg_resourcesactually ships)libpython3runtime dependency for the Python bindingspython3-pkg-resourcesis not defined anywhere in the packages feed. Both fail2ban and setools declared it as a runtime dependency, causing warnings during metadata generation. The correct package ispython3-setuptools, which providespkg_resources.