Skip to content

[chores] Add state category color variables#644

Open
atif09 wants to merge 2 commits intoopenwisp:masterfrom
atif09:issues/643-add-state-category-vars
Open

[chores] Add state category color variables#644
atif09 wants to merge 2 commits intoopenwisp:masterfrom
atif09:issues/643-add-state-category-vars

Conversation

@atif09
Copy link
Copy Markdown
Contributor

@atif09 atif09 commented Apr 8, 2026

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #643

Description of Changes

Added danger and warning variables to openwisp.css based on the device health state colors already used in openwisp-monitoring.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Warning

Rate limit exceeded

@atif09 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1a27234d-e517-4c39-8d31-fdc87bffca09

📥 Commits

Reviewing files that changed from the base of the PR and between 69b524c and e273b9e.

📒 Files selected for processing (1)
  • openwisp_utils/admin_theme/static/admin/css/openwisp.css
📝 Walkthrough

Walkthrough

Two semantic color design tokens were added to the CSS custom property palette in the :root selector: --ow-color-danger (#a72d1d) and --ow-color-warning (#ffb442). These variables complement the existing --ow-color-success to provide a complete set of state category colors for status representation across OpenWISP modules.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format with [chores] prefix and clearly describes the main change: adding state category color variables.
Description check ✅ Passed The description includes most required sections: checklist items, reference to issue #643, and a clear description of changes. However, manual testing, tests, and documentation updates are not checked.
Linked Issues check ✅ Passed The PR successfully implements the exact requirements from issue #643: adds --ow-color-danger (#a72d1d) and --ow-color-warning (#ffb442) CSS variables to openwisp.css.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue #643. Only the two required CSS custom properties were added to openwisp.css with no extraneous modifications.
Bug Fixes ✅ Passed This PR adds CSS custom properties for status state colors, which is a feature addition/chore per issue #643, not a bug fix in core user-facing functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Apr 8, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The PR successfully adds the requested CSS color variables (--ow-color-danger and --ow-color-warning) to align with device health state colors from openwisp-monitoring. The implementation matches the issue requirements exactly.

Files Reviewed (1 file)
  • openwisp_utils/admin_theme/static/admin/css/openwisp.css - Adds danger and warning color variables under the Success/Positive section

Reviewed by kimi-k2.5 · 93,707 tokens

Added danger and warning variables to openwisp.css based on the device health state colors already used in openwisp-monitoring.

Closes openwisp#643
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 8, 2026
@atif09 atif09 force-pushed the issues/643-add-state-category-vars branch from 4b25cd3 to 69b524c Compare April 8, 2026 22:26
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 8, 2026

Coverage Status

coverage: 97.476%. remained the same — atif09:issues/643-add-state-category-vars into openwisp:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

[chores] Add state category color variables to openwisp-utils

3 participants