Fix elementary Matrix construction bug#1372
Open
pstaabp wants to merge 2 commits into
Open
Conversation
pstaabp
force-pushed
the
bugfix/elem-matrix
branch
from
5e2e0d2 to
87c3de2
Compare
drgrice1
reviewed
Jan 29, 2026
fix the test and add some additional tests for elementary matrices.
pstaabp
force-pushed
the
bugfix/elem-matrix
branch
from
87c3de2 to
e799708
Compare
Member
Author
|
Fixed the POD documentation to make it clearer (and correct). |
Contributor
|
I opened a PR to your branch here, @pstaabp. There is one thing wrong in the POD you edited, just a typo or copy-paste oversight. And then I also tried to clarify the POD affected by this PR. |
Contributor
|
But if the PR I opened is good for you and gets merged, I can approve this. I tested the actual fix, and it's good. |
Contributor
|
And then also this can be rebased and retargeted to the 2.21 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug related to elementary matrices, fix the test and add some additional tests for elementary matrices.
This is to fix #1371