Skip to content

fix logic for when to check answer hints #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alex-Jordan wants to merge 2 commits into
base: develop
Choose a base branch
from
+13 −6
Open

fix logic for when to check answer hints #1317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c79dc9
clarify in POD for answerHints.pl that checkCorrect and checkTypes on…
Alex-Jordan May 21, 2026
b85a827
improve handling of context flags with answerHints
Alex-Jordan May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions macros/answers/answerHints.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ =head2 AnswerHints

=item C<S<< checkCorrect => 0 or 1 >>>

1 means check for messages even
if the answer is correct.
In the list of incorrect answers to compare the student's answer with, 1 means
for each CODE reference incorrect answer, check the student's answer against
that CODE reference incorrect answer for messages even if the student answer is
correct.
Default: 0

=item C<S<< replaceMessage => 0 or 1 >>>
Expand All @@ -45,9 +47,10 @@ =head2 AnswerHints

=item C<S<< checkTypes => 0 or 1 >>>

1 means only perform the test
if the student answer is the
same type as the correct one.
In the list of incorrect answers to compare the student's answer with, 1 means
for each CODE reference incorrect answer, check the student's answer against
that CODE reference incorrect answer for messages only when the the student
answer the same type as the correct answer.
Default: 1

=item C<S<< processPreview => 0 or 1 >>>
Expand Down Expand Up @@ -120,7 +123,6 @@ sub AnswerHints {
my $hash = $context->{answerHash};
$context->{answerHash} = $ans;
my $processPreview = $correct->getFlag('answerHintsProcessPreview', 0);
$context->{answerHash} = $hash;

while (@_) {
my $wrongList = shift;
Expand Down Expand Up @@ -172,6 +174,7 @@ sub AnswerHints {
}
}
}
$context->{answerHash} = $hash;
return $ans;
},
@_
Expand All @@ -191,6 +194,9 @@ sub Compare {
$ans->{typeError} = 0;
$ans->{ans_message} = $ans->{error_message} = "";
$ans->{score} = 0;
my $context = $self->context;
my $hash = $context->{answerHash};
$context->{answerHash} = $ans;

if ($self->address != $ans->{correct_value}->address) {
$ans->{correct_ans} = $self->string;
Expand All @@ -205,6 +211,7 @@ sub Compare {
$self->cmp_preprocess($ans);
$self->cmp_equal($ans);
$self->cmp_postprocess($ans) if !$ans->{error_message} && !$ans->{typeError};
$context->{answerHash} = $hash;
return $ans->{score} >= 1;
}

Expand Down
Loading