feat: Blink integration #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 135 files out of 242 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
c5195b9 to
5bb8820
Compare
Contributor
Author
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
5bb8820 to
dc828bb
Compare
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
8fc141d to
5fc475b
Compare
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
823881f to
f3a8999
Compare
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
e272b08 to
18625ed
Compare
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
18625ed to
d8002a4
Compare
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
d8002a4 to
fb0303b
Compare
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
fb0303b to
96ffe61
Compare
CGQAQ
force-pushed
the
feat/blink-integration
branch
from
96ffe61 to
e2bd366
Compare
This commit fixes error: FAILED: CMakeFiles/webf_core.dir/core/page.cc.obj expected unqualified-id 57 | WEBF_LOG(ERROR) << message << std::endl;
…and unify GC tracing logic - Migrated all `TraceAfterDispatch` methods to `Trace` with consistent overrides. - Updated `GCVisitor` logic for tracing relevant members across CSS and DOM objects. - Replaced `Member<>` with `std::shared_ptr<>` in several classes to modernize memory management. - Improved code clarity by removing unnecessary comments and redundant tracing implementations.
- Corrected computed results for `monospace` and various other font-family scenarios. - Fixed case sensitivity issues in expected values for consistency.
this fixes: integration_tests/specs/css/css-position/fixed.ts - should work with top and left offset when appended after window scrolled - should work with right and bottom offset when appended after window scrolled
fixed: integration_tests/specs/css/css-box/overflow.ts - scrollable area computed by max height children
- Removed handling of `StyleAttr` updates for inactive documents. - Added checks for document activity during inline style updates to prevent unnecessary commands. Fixed: integration_tests/specs/css/css-inline/bidirectional-text.ts - should handle inline element box model in RTL
The snapshot was using the fallback font because @font-face was being registered under a lowercased family name (google sans), while the element style uses Google Sans—and Flutter font family names are case-sensitive, so they didn’t match. Fixed by preserving the original font-family casing when bridging @font-face rules to Dart in core/css/style_engine.cc:433 (also the other registration paths in the same file). - Updated `font-family` values to retain original casing for accurate style resolution on the Dart side. - Removed unnecessary `LowerASCII` transformation to maintain consistency with other property handling. fixed: integration_tests/specs/css/css-fonts/font-face.ts - support loading font through font-face
- Added logic to recalculate declared-value styles to address style recalc lag during `UICommand` flush. - Prevents missing `kSetStyle` commands in snapshot tests.
CGQAQ
force-pushed
the
feat/blink-integration
branch
2 times, most recently
from
b732a50 to
e9764bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the codebase, primarily focusing on enhancing the CSS engine, improving build and logging configuration, and strengthening testing and code quality. The most significant changes include a major expansion of the CSS core, a new flexible logging system, and improved build/test documentation and reliability.
Key changes:
CSS Engine Enhancements
Build System & Logging Improvements
bridge/CMakeLists.txt, allowing per-category logging via environment variables or CMake options, and providing a master switch for all logging.bridge_sources.json5trigger CMake reconfiguration, preventing linker errors from missing sources.String encoding
Latin1String,UTF16String, andUTF8Stringfor owned string type alias for better readabilityLatin1StringView,UTF16StringView, andUTF8StringViewfor owned string type alias for better readabilityMiscellaneous
.gitignoreto exclude additional build artifacts and preview tools, improving repository cleanliness.foundation/metrics_registry.ccfor some metricsThese changes collectively improve the flexibility, reliability, and maintainability of both the CSS engine and the overall build/test workflow.