-
Notifications
You must be signed in to change notification settings - Fork 251
configuring genai model deployment with model readonly filesystem #4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dtrawins
wants to merge
23
commits into
main
Choose a base branch
from
ro-model_path-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
4e9850c
update ov runtime
dtrawins 933e65a
update
dtrawins 84f9cbb
update tests
dtrawins 2fc1646
update tests
dtrawins 02846f3
review changes
dtrawins 8167677
style
dtrawins eafe795
Enable generative deployment configuration with models on readonly fi…
dtrawins fdd58ed
fix unit test
dtrawins d00e994
Merge remote-tracking branch 'origin/main' into ro-model_path-configu…
dtrawins 5916e53
add more tests
dtrawins e34585a
style
dtrawins 030a31e
merge
dtrawins 826d183
Merge remote-tracking branch 'origin/main' into ro-model_path-configu…
dtrawins 2f668f4
refresh
dtrawins 2fd8c77
fix tests
dtrawins 14d1017
fix unit test for RO filesystem
dtrawins b35e4b2
fix windows unit tests execution
dtrawins eb95ca7
fix windows unit tests execution
dtrawins 67ef822
Merge branch 'main' into ro-model_path-configuration
dtrawins af16bb2
fix build for ovms_shared
dtrawins 7df366b
review changes
dtrawins 486f5c3
more tests
dtrawins b149635
Apply suggestions from code review
dtrawins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,18 +148,22 @@ bool Config::validateUserSettingsInConfigAddRemoveModel(const ModelsSettingsImpl | |
| } | ||
|
|
||
| bool Config::validate() { | ||
| if (this->serverSettings.serverMode == HF_PULL_MODE || this->serverSettings.serverMode == HF_PULL_AND_START_MODE) { | ||
| if (!serverSettings.hfSettings.sourceModel.size()) { | ||
| std::cerr << "source_model parameter is required for pull mode"; | ||
| return false; | ||
| } | ||
| if (!serverSettings.hfSettings.downloadPath.size()) { | ||
| std::cerr << "model_repository_path parameter is required for pull mode"; | ||
| return false; | ||
| } | ||
| if (this->serverSettings.hfSettings.task == UNKNOWN_GRAPH) { | ||
| std::cerr << "Error: --task parameter not set." << std::endl; | ||
| return false; | ||
| if (!this->serverSettings.hfSettings.sourceModel.empty() && this->serverSettings.hfSettings.task == UNKNOWN_GRAPH) { | ||
| std::cerr << "--source_model should be used combined with --task" << std::endl; | ||
| return false; | ||
| } | ||
| if (this->serverSettings.serverMode == HF_PULL_MODE || this->serverSettings.serverMode == HF_PULL_AND_START_MODE || this->serverSettings.serverMode == GENAI_CONFIGURE_AND_START) { | ||
| // When --task is used with --model_path (no HF pulling), sourceModel and downloadPath are not required | ||
| bool taskWithModelPath = (this->serverSettings.serverMode == HF_PULL_AND_START_MODE || this->serverSettings.serverMode == GENAI_CONFIGURE_AND_START) && !this->modelsSettings.modelPath.empty(); | ||
| if (!taskWithModelPath) { | ||
| if (!serverSettings.hfSettings.sourceModel.size()) { | ||
| std::cerr << "source_model parameter is required for pull mode"; | ||
| return false; | ||
| } | ||
| if (!serverSettings.hfSettings.downloadPath.size()) { | ||
| std::cerr << "model_repository_path parameter is required for pull mode"; | ||
| return false; | ||
|
Comment on lines
+155
to
+165
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug to fix. |
||
| } | ||
| } | ||
| if (this->serverSettings.hfSettings.task == TEXT_GENERATION_GRAPH) { | ||
| if (!std::holds_alternative<TextGenGraphSettingsImpl>(this->serverSettings.hfSettings.graphSettings)) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GenAI name but it has nothing to do with OpenVINO GenAI, I dont think its good naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkalinowski it refers to generative models which can be started via --model_path and --task. It configures runtime params based on CLI options and start the server.
Do you have some other proposals for the name?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just what the new feature is about: InMemoryGraphStart? TemporaryGraphStart? AutoGraphCreationStart? AutomaticGraphStart?
I mean here but also other enums etc