Skip to content

Conversation

@joearkay
Copy link
Contributor

I noticed when using the Home Assistant integration that relies on this library that some features were not showing up as entities. I think this is due to some deprecated APIs which are present in the current 050W configuration.

For me, I want to use the "feature": "heating.dhw.operating.modes.active" to set between comfort/eco/off

Please let me know if you would prefer me to update the Vitodens050W.json instead of creating a _2, however I didn't want to introduce any breaking changes.

I haven't yet had the time to study the library in full. Are there any other changes I should implement to update the library to add this feature?

@joearkay joearkay changed the title added version for my 050W added version for updated 050W Jan 18, 2025
@CFenner
Copy link
Member

CFenner commented Jan 19, 2025

Hey @joearkay thanks for providing the data! It would be nice it you update the existing file, that way we can see what changed. Note that the file needs to be sorted to do so.

@CFenner
Copy link
Member

CFenner commented Jan 19, 2025

I already started exposing the new function here #427 but as I do not have a DHW module, the motivation is not that high.

@joearkay
Copy link
Contributor Author

Hi @CFenner , Ok thanks. I'll close the PR and add a new one overwriting the same file. Aside, I was experimenting with the library yesterday and noticed that the setDomesticHotWaterOperatingMode() does actually interact with the heating.dhw.operating.modes.active API. It's just that there is only a 'setter' and no matching 'getter'. So with the exception of the 'getter' function, I guess my 'feature request' is null & void.

@joearkay joearkay closed this Jan 20, 2025
@CFenner
Copy link
Member

CFenner commented Jan 20, 2025

Reusing this would also be fine. Just rename the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants