Skip to content

Support specifying place name for Coordinate #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonardehrenfried merged 1 commit into from
Dec 16, 2025
Merged

Support specifying place name for Coordinate #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions client/src/main/java/org/opentripplanner/client/model/Coordinate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package org.opentripplanner.client.model;

public record Coordinate(double lat, double lon) implements PlaceParameter {
public record Coordinate(double lat, double lon, String name) implements PlaceParameter {
public Coordinate(double lat, double lon) {
this(lat, lon, String.format("%s,%s", lat, lon));
}

@Override
public String toString() {
Expand All @@ -9,6 +12,6 @@ public String toString() {

@Override
public String toPlaceString() {
return String.format("%s,%s::%s,%s", lat, lon, lat, lon);
return String.format("%s::%s,%s", name, lat, lon);
}
}
18 changes: 18 additions & 0 deletions client/src/test/java/org/opentripplanner/IntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,24 @@ public void planPlaceToPlace() throws IOException {
assertEquals(List.of(), leg.fareProducts());
}

@Test
public void planNamedCoordinate() throws IOException {
var result =
client.plan(
TripPlanParameters.builder()
.withFrom(new Coordinate(OSLO_EAST.lat(), OSLO_EAST.lon(), "Oslo East"))
.withTo(OSLO_WEST)
.withTime(LocalDateTime.now())
.withModes(RequestMode.TRANSIT)
.withNumberOfItineraries(3)
.build());

assertFalse(result.itineraries().isEmpty());
var firstLeg = result.itineraries().get(0).legs().get(0);

assertEquals("Oslo East", firstLeg.from().name());
}

@Test
public void planPlaceToPlaceWithSearchWindow() throws IOException {
var result =
Expand Down