fix: correct exception handling in get_external_ip and add validation…#3262
Open
amussara wants to merge 1 commit intoopentensor:masterfrom
Open
fix: correct exception handling in get_external_ip and add validation…#3262amussara wants to merge 1 commit intoopentensor:masterfrom
amussara wants to merge 1 commit intoopentensor:masterfrom
Conversation
… helper - Fix bug where get_external_ip() caught ExternalIPNotFound in each fallback block, but the actual exceptions (ConnectionError, AssertionError, Timeout, etc.) were never caught, causing the function to crash instead of falling through to the next service. - Replace bare assert with a dedicated _validate_ip_response() helper that strips whitespace and validates IP format. - Add timeout parameters to requests.get() and urllib_request.urlopen() calls to prevent indefinite hangs. - Add return type annotation to ip__str__(). - Add comprehensive test coverage for ip_version, ip_to_int validation, ip__str__ edge cases, _validate_ip_response, and get_external_ip fallthrough behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… helper
Welcome!
Due to GitHub limitations,
please switch to Preview for links to render properly.
Please choose the right template for your pull request: