-
Notifications
You must be signed in to change notification settings - Fork 102
Merge ctlplane-tls-cert-rotation tests into ctlplane-tls-custom-issuers #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
934d2e0 to
c2a30e7
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e80780ab962545efbab2bc34a9b6f0a8 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 02s |
Unrelated: |
|
recheck |
Consolidate these two TLS-related kuttl tests into a single comprehensive test suite that covers: - TLS ingress-only to full pod-level TLS transitions - Custom and default certificate issuer switching - Certificate rotation triggered by secret deletion - Custom certificate duration configuration - Certificate fingerprint verification before/after rotation Key changes: - Remove ctlplane-tls-cert-rotation test suite (merged into custom-issuers) - Renumber test steps (00-16) for proper sequencing - Add certificate fingerprint comparison to rotation assertions - Replace symlink with actual assert file for custom issuer deployment - Increase timeout for certificate issuer assertions (60s → 900s) - Improve error messages with namespace context This reduces test execution time by eliminating redundant OpenStack deployments while maintaining full TLS functionality coverage. Co-authored-by: Claude Assistant assistant@cursor.sh
c2a30e7 to
09ed090
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db3445e9a3ff4ae4ad8cd08594d33b25 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 04s |
Unrelated |
|
recheck |
|
/test i/prow/openstack-operator-build-deploy-kuttl |
|
@stuggi: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ci/prow/openstack-operator-build-deploy-kuttl |
|
@stuggi: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl |
|
@stuggi: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test openstack-operator-build-deploy-kuttl |
/test openstack-operator-build-deploy-kuttl |
|
After testing this across multiple CI runs and a few local environments, we're finding that the average gain in performance is so insignificant that it is almost nonexistent. Closing for now with this in mind. |
Consolidate these two TLS-related kuttl tests into a single comprehensive test suite that covers:
Key changes:
This reduces test execution time by eliminating redundant OpenStack deployments while maintaining full TLS functionality coverage.
Co-authored-by: Claude Assistant assistant@cursor.sh