Skip to content

Conversation

@abays
Copy link
Contributor

@abays abays commented Dec 10, 2025

Consolidate these two TLS-related kuttl tests into a single comprehensive test suite that covers:

  • TLS ingress-only to full pod-level TLS transitions
  • Custom and default certificate issuer switching
  • Certificate rotation triggered by secret deletion
  • Custom certificate duration configuration
  • Certificate fingerprint verification before/after rotation

Key changes:

  • Remove ctlplane-tls-cert-rotation test suite (merged into custom-issuers)
  • Renumber test steps (00-16) for proper sequencing
  • Add certificate fingerprint comparison to rotation assertions
  • Replace symlink with actual assert file for custom issuer deployment
  • Increase timeout for certificate issuer assertions (60s → 900s)
  • Improve error messages with namespace context

This reduces test execution time by eliminating redundant OpenStack deployments while maintaining full TLS functionality coverage.

Co-authored-by: Claude Assistant assistant@cursor.sh

@abays abays requested a review from stuggi December 10, 2025 13:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e80780ab962545efbab2bc34a9b6f0a8

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 02s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 06s
cifmw-crc-podified-edpm-baremetal FAILURE in 45m 18s
✔️ openstack-operator-tempest-multinode SUCCESS in 2h 05m 55s

@abays
Copy link
Contributor Author

abays commented Dec 11, 2025

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e80780ab962545efbab2bc34a9b6f0a8

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 02s ✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 06s ❌ cifmw-crc-podified-edpm-baremetal FAILURE in 45m 18s ✔️ openstack-operator-tempest-multinode SUCCESS in 2h 05m 55s

Unrelated:

FAILED - RETRYING: [localhost]: Wait for OpenStack subscription creation (1 retries left).

@abays
Copy link
Contributor Author

abays commented Dec 11, 2025

recheck

@abays abays marked this pull request as ready for review December 15, 2025 09:03
@openshift-ci openshift-ci bot requested review from dprince and olliewalsh December 15, 2025 09:03
@abays abays removed the request for review from olliewalsh December 15, 2025 09:04
Consolidate these two TLS-related kuttl tests into a single comprehensive test
suite that covers:

- TLS ingress-only to full pod-level TLS transitions
- Custom and default certificate issuer switching
- Certificate rotation triggered by secret deletion
- Custom certificate duration configuration
- Certificate fingerprint verification before/after rotation

Key changes:
- Remove ctlplane-tls-cert-rotation test suite (merged into custom-issuers)
- Renumber test steps (00-16) for proper sequencing
- Add certificate fingerprint comparison to rotation assertions
- Replace symlink with actual assert file for custom issuer deployment
- Increase timeout for certificate issuer assertions (60s → 900s)
- Improve error messages with namespace context

This reduces test execution time by eliminating redundant OpenStack
deployments while maintaining full TLS functionality coverage.

Co-authored-by: Claude Assistant assistant@cursor.sh
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db3445e9a3ff4ae4ad8cd08594d33b25

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 04s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 6m 20s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 41s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 55m 44s

@abays
Copy link
Contributor Author

abays commented Dec 15, 2025

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db3445e9a3ff4ae4ad8cd08594d33b25

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 04s ❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 6m 20s ✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 41s ✔️ openstack-operator-tempest-multinode SUCCESS in 1h 55m 44s

Unrelated

Unable to start service NetworkManager: Failed to start NetworkManager.service: Transaction for NetworkManager.service/start is destructive (ostree-remount.service has 'stop' job queued, but 'start' is included in transaction).
See system logs and 'systemctl status NetworkManager.service' for details.

@abays
Copy link
Contributor Author

abays commented Dec 15, 2025

recheck

@stuggi
Copy link
Contributor

stuggi commented Dec 15, 2025

/test i/prow/openstack-operator-build-deploy-kuttl

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@stuggi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test functional
/test images
/test openstack-operator-build-deploy
/test openstack-operator-build-deploy-kuttl
/test openstack-operator-build-deploy-kuttl-4-18
/test precommit-check

The following commands are available to trigger optional jobs:

/test openstack-operator-build-deploy-tempest

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openstack-k8s-operators-openstack-operator-main-functional
pull-ci-openstack-k8s-operators-openstack-operator-main-images
pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl
pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl-4-18
pull-ci-openstack-k8s-operators-openstack-operator-main-precommit-check
Details

In response to this:

/test i/prow/openstack-operator-build-deploy-kuttl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stuggi
Copy link
Contributor

stuggi commented Dec 15, 2025

/test ci/prow/openstack-operator-build-deploy-kuttl

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@stuggi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test functional
/test images
/test openstack-operator-build-deploy
/test openstack-operator-build-deploy-kuttl
/test openstack-operator-build-deploy-kuttl-4-18
/test precommit-check

The following commands are available to trigger optional jobs:

/test openstack-operator-build-deploy-tempest

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openstack-k8s-operators-openstack-operator-main-functional
pull-ci-openstack-k8s-operators-openstack-operator-main-images
pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl
pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl-4-18
pull-ci-openstack-k8s-operators-openstack-operator-main-precommit-check
Details

In response to this:

/test ci/prow/openstack-operator-build-deploy-kuttl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stuggi
Copy link
Contributor

stuggi commented Dec 15, 2025

/test pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@stuggi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test functional
/test images
/test openstack-operator-build-deploy
/test openstack-operator-build-deploy-kuttl
/test openstack-operator-build-deploy-kuttl-4-18
/test precommit-check

The following commands are available to trigger optional jobs:

/test openstack-operator-build-deploy-tempest

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openstack-k8s-operators-openstack-operator-main-functional
pull-ci-openstack-k8s-operators-openstack-operator-main-images
pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl
pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl-4-18
pull-ci-openstack-k8s-operators-openstack-operator-main-precommit-check
Details

In response to this:

/test pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stuggi
Copy link
Contributor

stuggi commented Dec 15, 2025

/test openstack-operator-build-deploy-kuttl

@abays
Copy link
Contributor Author

abays commented Dec 15, 2025

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 09ed090 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

/test openstack-operator-build-deploy-kuttl

@abays
Copy link
Contributor Author

abays commented Dec 16, 2025

After testing this across multiple CI runs and a few local environments, we're finding that the average gain in performance is so insignificant that it is almost nonexistent. Closing for now with this in mind.

@abays abays closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants