Add support for multiple Cinder Backups configuration #1714
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bf06427b62cf49d18cab0f61cfd7e57f ❌ openstack-k8s-operators-content-provider FAILURE in 12m 10s |
|
recheck |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/cinder-operator#575 is needed. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d526829bd0554de5adbbb3ea00a46e4f Warning: |
fmount
force-pushed
the
cback_listd
branch
2 times, most recently
from
ac0be86 to
5631e8f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5b5a02cc7c0d4672997072109154f2d6 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 39s |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bf22b29074a1473b9d0bb9e3e5410415 ❌ openstack-k8s-operators-content-provider FAILURE in 12m 37s |
This patch integrates CinderBackups support into OpenStackControlPlane CRD and adds the corresponding logic. It enables configuration of multiple Cinder Backup services and deprecates the existing interface [1]. [1] openstack-k8s-operators/cinder-operator#575 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
The cinder-operator dependency already landed and CI here is green. [1] https://issues.redhat.com/browse/OSPRH-23020 |
| if instance.Spec.Cinder.Template.CinderBackups != nil { | ||
| bkp := make(map[string]cinderv1.CinderBackupTemplate) | ||
| cinder.Spec.CinderBackups = &bkp | ||
| for name, backup := range *instance.Spec.Cinder.Template.CinderBackups { |
There was a problem hiding this comment.
do we have to make sure things get worked in a specific order since accessing maps can be in any order?
There was a problem hiding this comment.
No, each entry represents an independent instance that is usually connected to a different backend, so there's no ordering in general (like we do for cvol).
There was a problem hiding this comment.
as discussed on slack, lets follow up on this
There was a problem hiding this comment.
yes, I think I didn't get the question properly. When we iterate over the map[string]CinderBackupTemplate the ordered access is not guaranteed. This might result in an unnecessary reconciliation at least to the main cinder-operator controller.
We'll follow up on this particular point to ensure we access the map in order for both cinder components (cvol and cbak) but also manila-share and glance apis.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a77f462
into
openstack-k8s-operators:main
3 participants
This patch integrates
CinderBackupssupport intoOpenStackControlPlaneCRDand adds the corresponding logic.It enables configuration of multiple Cinder Backup services and deprecates the existing interface [1].
[1] openstack-k8s-operators/cinder-operator#575
Jira: https://issues.redhat.com/browse/OSPRH-22021