Enable NoNewRequiredFields in crd-schema-checker

[stuggi]

It was disabled with 553fc53. We should not add this setting in the script. If required, we should override the job to allow a wanted change in that regard.

[abays]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abays,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/32ee131ba32746b899741a00fdb3307f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 41s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 29m 17s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 33m 08s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 50m 23s

[abays]

recheck

[abays]

/test openstack-operator-build-deploy-kuttl

[rabi]

It was disabled with 553fc53. We should not add this setting in the script. If required, we should override the job to allow a wanted change in that regard.

Sorry, I was planning to re-enable it after that PR merged but was out sick. I don't prefer to override the pre-commit job as it can hide other issues and also folks don't review PRs that has not passed CI. Probably we should make it work for the scenarios where we're adding optional fields that should not fail.

[stuggi]

It was disabled with 553fc53. We should not add this setting in the script. If required, we should override the job to allow a wanted change in that regard.

Sorry, I was planning to re-enable it after that PR merged but was out sick. I don't prefer to override the pre-commit job as it can hide other issues and also folks don't review PRs that has not passed CI. Probably we should make it work for the scenarios where we're adding optional fields that should not fail.

for me personally, I prefer to override when someone checked the pre-commit logs manually and verified (could be running local with disable the check) that it is ok to merged the new parameters it reported.

[rabi]

for me personally, I prefer to override when someone checked the pre-commit logs manually and verified (could be running local with disable the check) that it is ok to merged the new parameters it reported.

Not all reviewers would check pre-commit logs for a failure before reviewing a PR. We need a better way IMO as both approaches are suboptimal.