-
Notifications
You must be signed in to change notification settings - Fork 102
Add docs for using custom provisionserver #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest |
1 similar comment
|
/retest |
| === Using a Custom Image with OpenStackProvisionServer | ||
|
|
||
| After building and pushing your container image, use it with the `OpenStackProvisionServer` | ||
| resource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needed to use a custom ProvisionServer?
The qcow2 container can be specified under osContainerImageUrl directly on baremetalSetTemplate, and that will automatically create a ProvisionServer serving that image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there are multiple options available here. The best option is to patch openstackversion so that it can be used across nodesets without patching them separately. The custom provisionserver (can be used with multiple nodesets) is useful as one can exhaust the provisionserver ports, if we create one for every nodeset which is the default. I'll update the docs to list the three options.
Signed-off-by: rabi <ramishra@redhat.com>
abays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@rabi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, rabi, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jira: https://issues.redhat.com/browse/OSPRH-22022