Skip to content

Conversation

@rabi
Copy link
Contributor

@rabi rabi commented Nov 18, 2025

@openshift-ci openshift-ci bot requested review from dprince and viroel November 18, 2025 01:26
@rabi
Copy link
Contributor Author

rabi commented Nov 18, 2025

/retest

1 similar comment
@rabi
Copy link
Contributor Author

rabi commented Nov 19, 2025

/retest

=== Using a Custom Image with OpenStackProvisionServer

After building and pushing your container image, use it with the `OpenStackProvisionServer`
resource:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed to use a custom ProvisionServer?
The qcow2 container can be specified under osContainerImageUrl directly on baremetalSetTemplate, and that will automatically create a ProvisionServer serving that image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there are multiple options available here. The best option is to patch openstackversion so that it can be used across nodesets without patching them separately. The custom provisionserver (can be used with multiple nodesets) is useful as one can exhaust the provisionserver ports, if we create one for every nodeset which is the default. I'll update the docs to list the three options.

Signed-off-by: rabi <ramishra@redhat.com>
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

@rabi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl db5b5c5 link unknown /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, rabi, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slagle slagle merged commit bf8aed5 into openstack-k8s-operators:main Nov 26, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants