-
Notifications
You must be signed in to change notification settings - Fork 102
Don't reconcile a failed deployment #1667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reconcile a failed deployment #1667
Conversation
eb63279 to
f0f8c7b
Compare
Don't reconcile a failed deployment after the required number of retries if there are changes in the nodeset or watched resources. Signed-off-by: rabi <ramishra@redhat.com>
f0f8c7b to
d666db5
Compare
|
/test functional |
|
recheck |
bshephar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
|
@bshephar: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, rabi, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bd6fca4
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr4 |
|
@rabi: new pull request created: #1707 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Don't reconcile a failed deployment after the required number of retries if there are changes in the nodeset or watched resources.
jira: OSPRH-21186