Skip to content

Conversation

@rabi
Copy link
Contributor

@rabi rabi commented Oct 23, 2025

Don't reconcile a failed deployment after the required number of retries if there are changes in the nodeset or watched resources.

jira: OSPRH-21186

@openshift-ci openshift-ci bot requested review from dprince and fultonj October 23, 2025 02:54
@rabi rabi force-pushed the deployment_reconcile branch from eb63279 to f0f8c7b Compare October 23, 2025 08:27
Don't reconcile a failed deployment after the required number of
retries if there are changes in the nodeset or watched resources.

Signed-off-by: rabi <ramishra@redhat.com>
@rabi rabi force-pushed the deployment_reconcile branch from f0f8c7b to d666db5 Compare October 23, 2025 09:46
@rabi
Copy link
Contributor Author

rabi commented Oct 23, 2025

/test functional

@rabi
Copy link
Contributor Author

rabi commented Oct 23, 2025

recheck

@rabi rabi requested a review from slagle October 29, 2025 06:34
Copy link
Contributor

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@bshephar: changing LGTM is restricted to collaborators

Details

In response to this:

lgtm :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, rabi, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bd6fca4 into openstack-k8s-operators:main Nov 20, 2025
8 checks passed
@rabi
Copy link
Contributor Author

rabi commented Nov 26, 2025

/cherry-pick 18.0-fr4

@openshift-cherrypick-robot

@rabi: new pull request created: #1707

Details

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants