Replace hardcoded namespace in KUTTL tests with $NAMESPACE variable#694
Merged
openshift-merge-bot[bot] merged 1 commit intoApr 22, 2026
Conversation
KEYSTONE_KUTTL_NAMESPACE is user-configurable in install_yamls (via ?= assignment), but test scripts and asserts had "keystone-kuttl-tests" hardcoded in service hostnames, secret metadata, and databaseHostname assertions. Tests would fail when run with a non-default namespace. Replace all hardcoded namespace references with the $NAMESPACE env var that KUTTL provides to test scripts. For databaseHostname validation, switch from static YAML asserts to script-based checks that dynamically construct the expected value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, Deydra71 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit d957b84
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KEYSTONE_KUTTL_NAMESPACE is user-configurable in install_yamls (via ?= assignment), but test scripts and asserts had "keystone-kuttl-tests" hardcoded in service hostnames, secret metadata, and databaseHostname assertions. Tests would fail when run with a non-default namespace.
Replace all hardcoded namespace references with the $NAMESPACE env var that KUTTL provides to test scripts. For databaseHostname validation, switch from static YAML asserts to script-based checks that dynamically construct the expected value.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com