Skip to content

Add glance section required by Cinder to use new glance location-api#631

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:location-a-pi
May 13, 2026
Merged

Add glance section required by Cinder to use new glance location-api#631
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
fmount:location-a-pi

Conversation

@fmount
Copy link
Copy Markdown
Contributor

@fmount fmount commented Apr 17, 2026

We need to register glance user in keystoneauth plugin to allow service to service communication and let Cinder access to the location-api glance calls. [1].

Jira: OSPRH-28617

[1] https://review.opendev.org/c/openstack/cinder/+/958716

region_name = {{ .Region }}
{{ end -}}

[glance]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread templates/cinder/config/00-global-defaults.conf
@konan-abhi
Copy link
Copy Markdown

Looks good to me!!

Copy link
Copy Markdown
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We need to register glance user in keystoneauth plugin to allow service
to service communication and let Cinder access to the location api
glance calls. [1]

[1] https://review.opendev.org/c/openstack/cinder/+/958716

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm label May 13, 2026
@fmount
Copy link
Copy Markdown
Contributor Author

fmount commented May 13, 2026

just rebased.

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/b0c5261dcb64491b91505298f032c3f6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 17m 39s
cinder-operator-kuttl FAILURE in 40m 24s
✔️ cinder-operator-tempest SUCCESS in 1h 54m 39s

@fmount
Copy link
Copy Markdown
Contributor Author

fmount commented May 13, 2026

recheck

@fmount
Copy link
Copy Markdown
Contributor Author

fmount commented May 13, 2026

ok tests look good, @stuggi to re-approve (thanks a lot for the help!)

Copy link
Copy Markdown
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgmt

@openshift-ci openshift-ci Bot added the lgtm label May 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit d2dc795 into openstack-k8s-operators:main May 13, 2026
6 checks passed
@rajathere
Copy link
Copy Markdown

Sorry for being late but this is a exact replica of the [nova] section which is desired.
We use the service user (cinder here) to communicate with glance and the only difference between upstream implementation and here is, based on wheather app creds are enabled, we make the decision to do password based auth or use app creds secret.
Overall, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants