Skip to content

[pcp_metrics] Make target hosts configurable via cifmw_pcp_metrics_hosts#3924

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:pcp
May 13, 2026
Merged

[pcp_metrics] Make target hosts configurable via cifmw_pcp_metrics_hosts#3924
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:pcp

Conversation

@rebtoor
Copy link
Copy Markdown
Contributor

@rebtoor rebtoor commented May 11, 2026

PCP hook playbooks hardcode hosts: all,!localhost, which causes
ansible-playbook to exit rc=2 when compute nodes are unreachable
(e.g. not yet provisioned or already torn down). This kills the
CI job for a metrics side-effect.

Introduce cifmw_pcp_metrics_hosts (default: all,!localhost) so that
downstream jobs can exclude host groups that are expected to be
unavailable. By not targeting those hosts at all, Ansible never
encounters UNREACHABLE errors and exits cleanly.

PCP hook playbooks hardcode hosts: all,!localhost, which causes
ansible-playbook to exit rc=2 when compute nodes are unreachable
(e.g. not yet provisioned or already torn down). This kills the
CI job for a metrics side-effect.

Introduce cifmw_pcp_metrics_hosts (default: all,!localhost) so that
downstream jobs can exclude host groups that are expected to be
unavailable. By not targeting those hosts at all, Ansible never
encounters UNREACHABLE errors and exits cleanly.

Co-Authored-By: Claude <noreply@anthropic.com>

Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@rebtoor rebtoor changed the title [pcp_metrics] Tolerate unreachable hosts in PCP hook playbooks [pcp_metrics] Make target hosts configurable via cifmw_pcp_metrics_hosts May 11, 2026
Copy link
Copy Markdown
Contributor

@michburk michburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evallesp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 42582bf into openstack-k8s-operators:main May 13, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants