[install_yamls] Add install_yamls pull repo capability#3774
Open
evallesp wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
[install_yamls] Add install_yamls pull repo capability#3774evallesp wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
evallesp wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
evallesp
force-pushed
the
install_yamls_add_pull
branch
from
5dace07 to
9075704
Compare
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the lowest precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e0b4c9dabda84293825f53cf2a3e9d68 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 54s |
evallesp
force-pushed
the
install_yamls_add_pull
branch
from
9075704 to
94f2d1f
Compare
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the lowest precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the lowest precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the lowest precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Deprecating cifmw_installyamls_repo_url, if previously used in all.yml file it's still valid. Warning message if set. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the lowest precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
install_yamls_add_pull
branch
from
94f2d1f to
4980556
Compare
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the lowest precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the lowest precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the lowest precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 19, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
michburk
reviewed
Mar 20, 2026
Comment on lines
+31
to
+32
| cifmw_installyamls_repo_url: "https://github.com/openstack-k8s-operators/install_yamls" | ||
| cifmw_install_yamls_version: "HEAD" |
Contributor
There was a problem hiding this comment.
If we move away from duplicating definitions in both in the defaults and in group_vars like my my comment in #3783 discusses, we can move away from the inconsistent cifmw_installyamls_ vs cifmw_install_yamls prefix situation going on here. We could give the repo_url var here some other name and give it the definition : "{{ cifmw_installyamls_repo_url }}".
evallesp
force-pushed
the
install_yamls_add_pull
branch
from
4980556 to
6b5fe69
Compare
evallesp
force-pushed
the
install_yamls_add_pull
branch
from
6b5fe69 to
6b7075a
Compare
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
| # NAMESPACE: openstack | ||
| # METALLB_POOL would be removed once https://github.com/openstack-k8s-operators/install_yamls/pull/356 merges. | ||
| cifmw_install_yamls_repo: "{{ cifmw_installyamls_repos | default(ansible_user_dir ~ '/src/github.com/openstack-k8s-operators/install_yamls') }}" | ||
| cifmw_install_yamls_repo_url: "{{ cifmw_installyamls_repo_url | default('https://github.com/openstack-k8s-operators/install_yamls') }}" |
Contributor
There was a problem hiding this comment.
not related to this PR, but would be a good idea to consolidate both these var styles (install_yamls and installyamls) into one later, as they're holding the same value. It'll be a bit difficult to decide which to choose as former var is specific for install_yamls role while the latter one is for global usage.
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 * openstack-k8s-operators#3792 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cc43132def3e44e0886701f422bf45fa ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 52s |
Contributor
Author
|
recheck |
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 * openstack-k8s-operators#3792 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
install_yamls_add_pull
branch
from
6b7075a to
19dc776
Compare
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 * openstack-k8s-operators#3792 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 * openstack-k8s-operators#3792 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ba70e3503a0149bd9755bbd6df647704 ❌ openstack-k8s-operators-content-provider FAILURE in 5m 28s |
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 * openstack-k8s-operators#3792 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
We're adding new variables: cifmw_install_yamls_src and cifmw_install_yamls_version This repo is cloned from zuul builting tools, now we can clone this when deploying outside zuul. Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
force-pushed
the
install_yamls_add_pull
branch
from
19dc776 to
6a126b7
Compare
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 * openstack-k8s-operators#3792 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
evallesp
added a commit
to evallesp/ci-framework
that referenced
this pull request
Mar 24, 2026
This file in conjuction with: * openstack-k8s-operators#3774 * openstack-k8s-operators#3772 * openstack-k8s-operators#3792 Allows ci-framework to clone those repos (architecture was already enabled) when repositories are not already there due to zuul has not marked them as required-projects or because we're running them outside the zuul ecosystem. This is the almost the lowest in precedence, so if we still have these vars defined at zuul level or defaults-vars (passed as extra-vars) or scenarios files, this file is not taken into consideration. Precedence chain: * Zuul repos * cifmw_reproducer_repositories * cifmw_reproducer_default_repositories * Git pull logic in each of the roles Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5e872b081f634c288e4f048de61be9af ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 09s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're adding new variables: cifmw_install_yamls_src and cifmw_install_yamls_version This repo is cloned from zuul builting tools, now we can clone this when deploying outside zuul.