Skip to content

Improve review-ready-label workflow #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amartyasinha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve review-ready-label workflow #3561

amartyasinha wants to merge 1 commit into from

Conversation

@amartyasinha
Copy link
Contributor

@amartyasinha amartyasinha commented Dec 17, 2025 •
edited
Loading

If a PR has do-not-merge/work-in-progress label, it should not get Ready for Review label.

Depends-On: #3562
Depends-On: #3563

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bshewale for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amartyasinha amartyasinha force-pushed the improve_review-ready-label branch 2 times, most recently from 6e7f300 to 322aa05 Compare December 17, 2025 09:26
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 17, 2025

This change depends on a change that failed to merge.

Change #3562 is needed.

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Dec 17, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 17, 2025

This change depends on a change that failed to merge.

Change #3562 is needed.

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Dec 17, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 17, 2025

This change depends on a change that failed to merge.

Change #3562 is needed.

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Dec 17, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 17, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d6884afaa0e64003a55c9436cb014de0

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 15s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 02s
❌ build-push-container-cifmw-client FAILURE in 24m 20s

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Dec 17, 2025

recheck

@amartyasinha amartyasinha force-pushed the improve_review-ready-label branch from 322aa05 to a082c2e Compare December 17, 2025 11:00
amartyasinha added a commit to amartyasinha/ci-framework that referenced this pull request Dec 17, 2025
@amartyasinha
DNM: Testing review ready workflow
69c6ff7 
The change made in openstack-k8s-operators#3561 is being tested here

Signed-off-by: Amartya Sinha <amsinha@redhat.com>
@amartyasinha amartyasinha mentioned this pull request Dec 17, 2025
Closed
@amartyasinha amartyasinha force-pushed the improve_review-ready-label branch from a082c2e to ed37190 Compare December 17, 2025 11:45
@amartyasinha
Copy link
Contributor Author

amartyasinha commented Dec 17, 2025

recheck

@amartyasinha
Improve review-ready-label workflow
3a89795 
If a PR has `do-not-merge/work-in-progress` label, it should not get `Ready for Review` label.

Signed-off-by: Amartya Sinha <amsinha@redhat.com>
Assisted-by: Claude model claude-sonnet-4@20250514
@amartyasinha amartyasinha force-pushed the improve_review-ready-label branch from ed37190 to 3a89795 Compare December 17, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@amartyasinha