Skip to content

[multiple] Update no_log to use cifmw_nolog variable #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rebtoor wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[multiple] Update no_log to use cifmw_nolog variable #3544

rebtoor wants to merge 2 commits into from
+26 −25

Conversation

@rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Dec 10, 2025 •
edited
Loading

This change enhances the debugging experience and ensures conistent usage of the no_log variable throughout the CI Framework repository.

@rebtoor rebtoor requested a review from a team December 10, 2025 05:06
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yorabl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amartyasinha
Copy link
Contributor

amartyasinha commented Dec 10, 2025

Any specific reason to not include this var in group_vars?

@rebtoor
Copy link
Contributor Author

rebtoor commented Dec 10, 2025

Any specific reason to not include this var in group_vars?

@amartyasinha none from my pov.

But with this PR I was just trying to address all those cases where the variable was hardcoded to true despite the pattern of defining cifmw_nolog to control that behavior. (It was in the update role in my case but i found that antipattern in several roles and playbooks)

@rebtoor
[multiple] Update no_log to use cifmw_nolog variable
ec57d7f 
This change enhances the debugging experience and ensures conistent
usage of the no_log variable throughout the CI Framework repository.

Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@rebtoor rebtoor force-pushed the update_no_log branch 2 times, most recently from 5a87cd8 to a7aa470 Compare December 10, 2025 05:55
@rebtoor
[multiple] Add cifmw_nolog variable to group_vars/all.yml
3d9f1cf 
Its default value is set to true to avoid logging of sensitive data by default.
It can be overridden by setting it to false.

Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@rebtoor
Copy link
Contributor Author

rebtoor commented Dec 10, 2025

@amartyasinha fixed with 3d9f1cf :)

@evallesp
Copy link
Contributor

evallesp commented Dec 10, 2025

(non-blocking) question: I'm unsure now if we want to set in each of the default of the var as we're moving it to the group_vars.
Definetely it doesn't hurt!

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 10, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e127fa37065f42c7aaea8e631391cd11

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 31m 38s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 55s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 17m 15s
❌ podified-multinode-hci-deployment-crc RETRY_LIMIT in 10m 17s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 42s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 54s
✔️ build-push-container-cifmw-client SUCCESS in 17m 30s
✔️ cifmw-molecule-adoption_osp_deploy SUCCESS in 3m 50s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 14s
✔️ cifmw-molecule-ci_setup SUCCESS in 3m 39s
✔️ cifmw-molecule-cifmw_ceph_client SUCCESS in 4m 43s
✔️ cifmw-molecule-cifmw_external_dns SUCCESS in 2m 16s
✔️ cifmw-molecule-devscripts SUCCESS in 10m 27s
✔️ cifmw-molecule-fdp_update_container_images SUCCESS in 2m 17s
✔️ cifmw-molecule-install_openstack_ca SUCCESS in 28m 34s
✔️ cifmw-molecule-manage_secrets SUCCESS in 16m 06s
✔️ cifmw-molecule-update SUCCESS in 5m 04s

@rebtoor
Copy link
Contributor Author

rebtoor commented Dec 10, 2025

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 10, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c6a08b63edc54b6b8c9cc2e2ed311ab9

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 31m 24s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 15s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 43m 35s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 16m 14s
❌ podified-multinode-hci-deployment-crc RETRY_LIMIT in 11m 00s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 21s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 32s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 52s
✔️ build-push-container-cifmw-client SUCCESS in 19m 23s
✔️ cifmw-molecule-adoption_osp_deploy SUCCESS in 3m 49s
✔️ cifmw-molecule-ci_dcn_site SUCCESS in 2m 25s
✔️ cifmw-molecule-ci_setup SUCCESS in 3m 34s
✔️ cifmw-molecule-cifmw_ceph_client SUCCESS in 4m 25s
✔️ cifmw-molecule-cifmw_external_dns SUCCESS in 2m 24s
✔️ cifmw-molecule-devscripts SUCCESS in 10m 36s
✔️ cifmw-molecule-fdp_update_container_images SUCCESS in 2m 22s
✔️ cifmw-molecule-install_openstack_ca SUCCESS in 29m 07s
✔️ cifmw-molecule-manage_secrets SUCCESS in 29m 39s
✔️ cifmw-molecule-update SUCCESS in 4m 55s

@github-actions
Copy link

github-actions bot commented Dec 26, 2025

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evallesp evallesp evallesp approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rebtoor @amartyasinha @evallesp