[multiple] Consolidate openstack ns var: cifmw_openstack_namespace #3533
+96
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
amartyasinha
force-pushed
the
ns_group_vars
branch
from
08411ec to
e81f770
Compare
|
This change depends on a change that failed to merge. Change #3534 is needed. |
Contributor
Author
|
recheck |
amartyasinha
force-pushed
the
ns_group_vars
branch
4 times, most recently
from
5370e51 to
fb7bc49
Compare
amartyasinha
changed the title
amartyasinha
force-pushed
the
ns_group_vars
branch
from
fb7bc49 to
04826bc
Compare
Contributor
Author
|
recheck |
Contributor
Author
|
recheck |
Contributor
Author
|
recheck |
Contributor
Author
|
recheck |
amartyasinha
force-pushed
the
ns_group_vars
branch
from
04826bc to
e994792
Compare
There are multiple variables related to openstack namespace in OCP. This commit tries to consolidate them all with a single variable defined in group_vars. At some places, ns var were being read from cifmw_install_yamls_defaults, thus it is being used as the value for cifmw_openstack_namespace var in group_vars along with default value of openstack. Signed-off-by: Amartya Sinha <amsinha@redhat.com>
amartyasinha
force-pushed
the
ns_group_vars
branch
from
e994792 to
ee3f29a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple variables related to openstack namespace in OCP. This commit tries to consolidate them all with a single variable defined in group_vars. At some places, ns var were being read from cifmw_install_yamls_defaults and they are left unchanged.
Depends-On: #3534