-
Notifications
You must be signed in to change notification settings - Fork 11
switch HA-proxy tests to h1load client #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e118d97 to
67ed709
Compare
nhorman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but I'm a bit confused as to how h1load gets setup with this test. Is it meant to be run by hand independently?
it's run by it's the the part up to collecting results is mostly done. I'm still working on gnuplot scripts to post-process data. I will include them to separate PR. |
|
Sasha, before you spend too much time on gnuplot scripts, I'll share you some hints to ease your job (e.g. using -ll instead of -l to have raw numbers instead of human-friendly ones). I'm also finalizing a few small changes that ease selecting relevant lines if you want to compute averages. I'll ping you soon about this. |
|
Walter, thanks a lot. I will be also happy for tips on how to set the h1load arguments. to run benchmark tests. |
|
Agreed, that's what I want to show you because it's not quite hard. With -d you can set the duration of the test, with -s you can configure a slow ramp-up period (absolutely necessary to avoid measurement errors), and I'll also show you how to pick the relevant values to provide a meaningful measure. On the haproxy side, using taskset is an easy and convenient way to select the number of threads you want. I'll try to dedicate you some time next week to work on this. Today I'm busy chasing a few bugs. |
be2f9de to
7d10408
Compare
jogme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First iteration - only cosmetics
| PORT_EC_REUSE=${BENCH_PORT_EC_REUSE:-10200} | ||
| PORT_EC=${BENCH_PORT_EC:-10300} | ||
| HAPROXY_VERSION='v3.2.0' | ||
| CERT_SUBJ=${BENCH_CERT_SUBJ:-'/CN=localhost'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicity; already present on line 20
| PORT_EC=${BENCH_PORT_EC:-10300} | ||
| HAPROXY_VERSION='v3.2.0' | ||
| CERT_SUBJ=${BENCH_CERT_SUBJ:-'/CN=localhost'} | ||
| CERT_ALT_SUBJ=${BENCH_CERT_ALT_SUBJ:-'subjectAltName=DNS:localhost,IP:127.0.0.1'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above; line 21
| CERT_SUBJ=${BENCH_CERT_SUBJ:-'/CN=localhost'} | ||
| CERT_ALT_SUBJ=${BENCH_CERT_ALT_SUBJ:-'subjectAltName=DNS:localhost,IP:127.0.0.1'} | ||
| PROXY_CHAIN=${BENCH_PROXY_CHAIN:-21} | ||
| HOST=${BENCH_HOST:-'127.0.0.1'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above; line 22 (and used on line 23)
| typeset SSL_LIB=$1 | ||
| typeset RSACERTKEY='' | ||
| typeset ECCERTKEY='' | ||
| typeset HAPROXY_CONF='etc/haproxy.conf' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the value is changed before usage on line 181, so this assignment seems redundant
| PROXYCERT=${RSACERTKEY} | ||
| else | ||
| PROXYCERT=${ECCERTKEY} | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is off here and a few places also below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, tab vs. spaces, thanks for spotting that.
bench-scripts/bench_run_haproxy.sh
Outdated
| RESULT=${RESULT_DIR}/h1load-dh-rsa-reuse-${THREAD_COUNT}-${SSL_LIB}.out | ||
| PORT=$(( ${PORT_RSA_REUSE} + ${PROXY_CHAIN} )) | ||
| LD_LIBRARY_PATH=${OPENSSL_DIR}/lib ${H1LOAD} \ | ||
| -l \ | ||
| -P \ | ||
| -d ${TEST_TIME} \ | ||
| -c 500 \ | ||
| -t ${THREAD_COUNT} \ | ||
| -u \ | ||
| --tls-reuse \ | ||
| ${BASE_URL}${PORT} > ${RESULT} || exit 1 | ||
|
|
||
| RESULT=${RESULT_DIR}/h1load-dh-rsa-noreuse-${THREAD_COUNT}-${SSL_LIB}.out | ||
| PORT=$(( ${PORT_RSA} + ${PROXY_CHAIN} )) | ||
| LD_LIBRARY_PATH=${OPENSSL_DIR}/lib ${H1LOAD} \ | ||
| -l \ | ||
| -P \ | ||
| -d ${TEST_TIME} \ | ||
| -c 500 \ | ||
| -t ${THREAD_COUNT} \ | ||
| -u \ | ||
| ${BASE_URL}${PORT} > ${RESULT} || exit 1 | ||
|
|
||
| if [[ -x ${SIEGE} ]] ; then | ||
| RESULT=${RESULT_DIR}/siege-dh-rsa-noreuse-${THREAD_COUNT}-${SSL_LIB}.out | ||
| LD_LIBRARY_PATH=${OPENSSL_DIR}/lib ${SIEGE} \ | ||
| -b \ | ||
| -c ${THREAD_COUNT} \ | ||
| -t ${TEST_TIME}S \ | ||
| "${BASE_URL}${SIEGE_PORT_RSA}/?s=1k" 2> ${RESULT} 1> /dev/null | ||
| fi | ||
|
|
||
| RESULT=${RESULT_DIR}/h1load-ec-dsa-reuse-${THREAD_COUNT}-${SSL_LIB}.out | ||
| PORT=$(( ${PORT_EC_REUSE} + ${PROXY_CHAIN} )) | ||
| LD_LIBRARY_PATH=${OPENSSL_DIR}/lib ${H1LOAD} \ | ||
| -l \ | ||
| -P \ | ||
| -d ${TEST_TIME} \ | ||
| -c 500 \ | ||
| -t ${THREAD_COUNT} \ | ||
| -u \ | ||
| --tls-reuse \ | ||
| ${BASE_URL}${PORT} > ${RESULT} || exit 1 | ||
|
|
||
| RESULT=${RESULT_DIR}/h1load-ec-dsa-noreuse-${THREAD_COUNT}-${SSL_LIB}.out | ||
| PORT=$(( ${PORT_EC} + ${PROXY_CHAIN} )) | ||
| LD_LIBRARY_PATH=${OPENSSL_DIR}/lib ${H1LOAD} \ | ||
| -l \ | ||
| -P \ | ||
| -d ${TEST_TIME} \ | ||
| -c 500 \ | ||
| -t ${THREAD_COUNT} \ | ||
| -u \ | ||
| ${BASE_URL}${PORT} > ${RESULT} || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be put into a for to eliminate duplicity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going for what you suggest however I'm not entirely convinced it makes code easier to read/modify. whatever if you will like it can be kept or code can be reverted to what I have now in PR.
| # note this is hack because we always assume | ||
| # openssl-master is installed in INSTALL root | ||
| # | ||
| $(LD_LIBRARY_PATH="${INSTALL_ROOT}/openssl-master/lib" "${OPENSSL}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there can be a check added if the openssl-master dir is already installed
|
You comment that you aren't using siege as a client - but I still see a pile of references there - is this expected? Is it still actually used? If so the PR comment should be updated. |
I will fix the comment. I think it is useful to keep both tools working just for a cross check. |
This change also simplifies current HA-proxy test set up.
Testing no longer requires apache/nginx server as backend.
Test also uses h1load [1] client now.
The pull request also installs httpterm [2] http/1.1 server.
It's used as a backend for tests perfromed by siege [3].
The HA-proxy configuration for testing matches the configuration
used in 'State of SSL stacks' [4] write up.
The h1load client currently runs with options as follows :
h1load
-l \ # long results, output expected by h1load shell script
-P \ # report also percentiles for gathared data
-d ${TEST_TIME} \ # test duration, TEST_TIME is 10secs
-c 500 \ # 500 concurrent connections
-t ${THREAD_COUNT} \ # gather data for 1, 2, 4, 8, 16, 32, 64 threads
-u \ # use runtime instead of system time
${BASE_URL}${PORT} # url where to connect to
[1] https://github.com/wtarreau/h1load
[2] https://github.com/wtarreau/httpterm
[3] https://github.com/JoeDog/siege
[4] https://www.haproxy.com/blog/state-of-ssl-stacks
1c43370 to
7e377ad
Compare
This change simplifies current HA-proxy test set up. Testing no longer requires apache/nginx server as backend. Instead of using siege as a client the test uses
h1load [1].
The pull request also install httpterm [2] http/1.1 server. It's unused currently.
The HA-proxy configuration for testing matches the configuration used in 'State of SSL stacks' write up.
The h1load client currently runs with options as follows :
h1load
-l \ # long results, output expected by h1load shell script
-P \ # report also percentiles for gathared data
-d ${TEST_TIME} \ # test duration, TEST_TIME is 10secs
-c 500 \ # 500 concurrent connections
-t ${THREAD_COUNT} \ # gather data for 1, 2, 4, 8, 16, 32, 64 threads
-u \ # use runtime instead of system time
${BASE_URL}${PORT} # url where to connect to
The options above is just the initial version.
[1] https://github.com/wtarreau/h1load
[2] https://github.com/wtarreau/httpterm
[3] https://www.haproxy.com/blog/state-of-ssl-stacks