test: NonScalingOverlay + ReactNativeZoomableView test suite (274 tests, 29 suites) #180
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,3 +23,5 @@ jobs: | |
| run: yarn run lint | ||
| - name: Build | ||
| run: yarn build | ||
| - name: Run unit tests | ||
| run: yarn test --ci --runInBand | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| module.exports = { | ||
| presets: ['module:@react-native/babel-preset'], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import 'react-native-gesture-handler/jestSetup'; | ||
|
|
||
| // Reanimated 3 ships an official mock that runs animated styles synchronously. | ||
| jest.mock('react-native-reanimated', () => { | ||
| // eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-unsafe-return | ||
| return require('react-native-reanimated/mock'); | ||
| }); | ||
|
|
||
| // Stub RN's renderer shim so importing RNGH's utils.js doesn't crash on | ||
| // `ReactNativeRenderer-dev` evaluation. RNGH's `useViewRefHandler` calls | ||
| // `findNodeHandle(ref)` via `RendererImplementation.js`, which lazily | ||
| // requires `ReactNativeRenderer-dev.js` and crashes under jest with | ||
| // `Cannot read properties of undefined (reading 'S')` (the documented | ||
| // Phase A §7a crash). We hand back a stable fake nodeHandle (42) — the | ||
| // gesture isn't attached to a real native view, but `attachHandlers` | ||
| // still completes and registers the testID. This mock is additive: it | ||
| // only intercepts a render path that tests don't otherwise reach. | ||
| // Hoisted here per phase E probe §6.1 so real-RNGH tests across the | ||
| // suite inherit it without per-file repetition. | ||
| jest.mock( | ||
| 'react-native/Libraries/Renderer/shims/ReactNative', | ||
| () => ({ | ||
| __esModule: true, | ||
| default: { | ||
| findHostInstance_DEPRECATED: (ref: unknown) => ref, | ||
| findNodeHandle: () => 42, | ||
| render: () => null, | ||
| unmountComponentAtNodeAndRemoveContainer: () => null, | ||
| unstable_batchedUpdates: (fn: () => void) => { | ||
| fn(); | ||
| }, | ||
| dispatchCommand: () => null, | ||
| sendAccessibilityEvent: () => null, | ||
| isChildPublicInstance: () => false, | ||
| }, | ||
| }), | ||
| { virtual: false } | ||
| ); | ||
|
|
||
| // Reanimated mock recommends silencing the layout-animation warning. | ||
| // (See https://docs.swmansion.com/react-native-reanimated/docs/guides/testing/) | ||
| jest.spyOn(global.console, 'warn').mockImplementation((msg: unknown) => { | ||
| if (typeof msg === 'string' && msg.includes('Reanimated 2')) return; | ||
| // fall through other warnings | ||
| }); | ||
|
There was a problem hiding this comment. jest.setup suppresses all console.warn, not just ReanimatedMedium Severity The   Reviewed by Cursor Bugbot for commit dd2672e. Configure here. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPECS.md documents internal implementation details for NonScalingOverlay
Low Severity
The NonScalingOverlay contract section includes implementation details that violate the SPECS.md authoring rules. Specifically: the "Transform formula" subsection documents the exact 5-element transform array structure with index positions (
transform[3..4]), the "Mounting rules" subsection references internal tree topology relative toGestureDetector, and source ordering withinReactNativeZoomableView. These are implementation internals, not consumer-observable behavior.Triggered by learned rule: SPECS.md must document consumer-observable behavior only
Reviewed by Cursor Bugbot for commit dd2672e. Configure here.