Skip to content

fix: sanitize hyphens in get_asset_key_str to prevent KeyError on hyphenated internal asset names #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connordouglashanna wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: sanitize hyphens in get_asset_key_str to prevent KeyError on hyphenated internal asset names #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76184d5
fix: error caused by lack of normalization for hyphenated catalog names
connordouglashanna Apr 2, 2026
f7818bb
test: hyphenated catalog, db, and model names are now dehyphenated
connordouglashanna Apr 2, 2026
85b27bf
fix: typo in the test string assertion
connordouglashanna Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dagster_sqlmesh/test_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from dagster_sqlmesh.translator import SQLMeshDagsterTranslator


def test_get_asset_key_str_sanitizes_hyphens():
translator = SQLMeshDagsterTranslator()
result = translator.get_asset_key_str("my-catalog.my-schema.my-model")
assert result == "sqlmesh__my_catalog_my_schema_my_model"
assert "-" not in result
4 changes: 2 additions & 2 deletions dagster_sqlmesh/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ def get_asset_key_str(self, fqn: str) -> str:
"""
table = exp.to_table(fqn)
asset_key_name = [table.catalog, table.db, table.name]
return "sqlmesh__" + "_".join(asset_key_name)

return ("sqlmesh__" + "_".join(asset_key_name)).replace("-", "_")

def get_tags(self, context: Context, model: Model) -> dict[str, str]:
"""Get Dagster asset tags for a SQLMesh model.
Expand Down