-
-
Notifications
You must be signed in to change notification settings - Fork 7
UI & translation improvemements, updated IfcOpenShell Wheel (with IFC4.3 support) #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
louistrue
wants to merge
18
commits into
opensource-construction:main
Choose a base branch
from
louistrue:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new HTML report generation component with enhanced translation capabilities for validation results. - Added support for multiple languages in the report, improving accessibility for non-English speakers. - Implemented a new `IDSTranslationService` to handle dynamic translations and improve report content. - Updated existing components to integrate the new report generation logic and ensure seamless user experience. - Refactored file processing logic to utilize the new HTML report features, enhancing overall functionality.
- Updated the `HTMLTemplateRenderer` component to improve report generation logic and enhance translation support. - Refactored the `IDSTranslationService` to streamline translation processes and remove unnecessary dependencies. - Enhanced type safety by introducing TypeScript interfaces for template data and validation results. - Simplified the `useEnhancedHtmlReport` hook by removing the i18n dependency, improving usability. - Improved handling of conditional sections and loops in the HTML template rendering process.
- Refactored the report viewer to render content in a sandboxed iframe, improving security and preventing XSS vulnerabilities. - Updated the HTML report generation logic to include detailed metrics for passed and failed entities, enhancing reporting accuracy. - Simplified translation handling in the report generation process, ensuring consistency across multiple languages. - Removed unnecessary translation keys from French, Italian, and Romansh locales to streamline localization efforts.
- Updated the `HTMLTemplateRenderer` to improve handling of variable replacements, ensuring proper HTML escaping to prevent XSS vulnerabilities. - Refactored the `useEnhancedHtmlReport` hook to escape page titles and improve safety in HTML content generation. - Enhanced the logic for replacing variables in the report template, ensuring that all dynamic content is safely rendered.
- Added tooltip for downloading HTML reports in multiple languages, improving user experience. - Refactored HTML report download logic to simplify parameters and enhance filename generation. - Updated translation service to support language overrides for validation results, ensuring accurate translations across different languages.
- Updated HTML report generation to include detailed metrics for applicable entities, improving reporting accuracy. - Enhanced translation service to support new keys for better localization across multiple languages. - Simplified the handling of conditional sections in the report template, ensuring consistent rendering of validation results. - Removed checks for IFC version applicability in the report, streamlining the validation process.
…ment - Introduced a processing lock to prevent concurrent validation runs, enhancing stability. - Updated the IFC header normalization logic to handle edge cases more effectively. - Implemented per-run file isolation, creating unique directories for input and output files to avoid conflicts. - Enhanced error handling and cleanup procedures for temporary files after processing. - Updated report generation paths to use dynamic variables for better flexibility.
- Modified the SpecificationResult interface to allow 'skipped' as a valid status. - Enhanced the translation logic to set the status to 'skipped' for proper template rendering when applicable.
- Updated the validation types to improve type safety and consistency across the application. - Refactored the IDSTranslationService to utilize new validation interfaces, streamlining translation processes. - Enhanced the HTML report generation logic to ensure accurate rendering of validation results with updated entity properties.
- Renamed `pyodideWorker.js` to `pyodideWorkerClean.js` for clarity and consistency. - Removed the old `pyodideWorker.js` file to streamline the project structure. - Updated the README to reflect the new file name and improve documentation clarity. - Enhanced the `useEnhancedHtmlReport` hook to improve variable replacement logic, ensuring safer HTML rendering.
- Added support for multiple languages including German, French, Italian, and Romansh. - Configured language detection to prioritize query string, local storage, and navigator settings. - Updated i18next initialization to load only the language and improve debugging options.
- Added new translation keys for failure reasons and specifications not applying to certain IFC versions across multiple languages (German, French, Italian, Romansh). - Updated the IDSTranslationService to improve handling of various validation error messages, ensuring accurate translations based on context. - Refactored HTML report generation to incorporate translated failure reasons, enhancing user experience and localization.
- Added new translation keys for checks passed, elements passed, failure reasons, specifications not applying to IFC versions, and applicability. - Updated the translation variables to include the new keys, improving localization and user experience in the HTML report.
Improved HTML report generation and translation support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.