HPUX-876: Map Korrel8r resources to icons #186
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@alanconway: This pull request references HPUX-876 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
the
approved
alanconway
force-pushed
the
troubleshooting-icons
branch
2 times, most recently
from
4d36800 to
ac5372e
Compare
|
All icons assigned so far: 
|
|
Examplein use: |
alanconway
force-pushed
the
troubleshooting-icons
branch
from
ac5372e to
3bb3b97
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/label ux-approved |
openshift-ci
bot
added
the
ux-approved
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@alanconway: This pull request references HPUX-876 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jgbernalp @PeterYurkovich I've added a commit to clean up unused dependencies, I didn't squash it into the icon commit since it's somewhat independent. |
alanconway
force-pushed
the
troubleshooting-icons
branch
from
ba16098 to
84985eb
Compare
- Most icons from fontawesome or patternfly - Kubernetes ships-wheel taken from uxwing, not available in fa or pf. - Remove domain name from graph labels, redundant with icon. - Makefile: build-image TAG defaults to VERSION or 'latest' chore: NO-JIRA: Dependency clean-up Package cleanup: - Remove unused package `comment-json` and script `i18n-scripts/lexers.js` - Removed several other unused packages - see packages.json - Added .depcheckrc to give clean output from `npx depcheck` - Add TAG variable to Makefile for better control of image names. - Upgraded some packages to fix `npm audit` warnings NOTE: one audit warning is not fixed, it wants a drastic downgrade cypress@14.5.4 => 4.2.0 This looks like a mistake. Here's the notice from `npm audit` Severity: high qs's arrayLimit bypass in its bracket notation allows DoS via memory exhaustion - GHSA-6rw7-vpxm-498p fix available via `npm audit fix --force` Will install cypress@4.2.0, which is a breaking change
alanconway
force-pushed
the
troubleshooting-icons
branch
from
84985eb to
6ace991
Compare
|
@jgbernalp @PeterYurkovich changed the k8s icon for a transparent one (works in dark & light mode) and squashed the commits. LGTM me please! |
|
@alanconway: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
/cc @PeterYurkovich