Skip to content

ci: add qodo review config#68

Open
smith-xyz wants to merge 2 commits into
openshift:mainfrom
smith-xyz:add-qodo-config
Open

ci: add qodo review config#68
smith-xyz wants to merge 2 commits into
openshift:mainfrom
smith-xyz:add-qodo-config

Conversation

@smith-xyz
Copy link
Copy Markdown
Contributor

@smith-xyz smith-xyz commented May 19, 2026

Adding qodo config for ai assisted reviews

@openshift-ci openshift-ci Bot requested review from rhmdnd and richardsonnick May 19, 2026 14:38
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smith-xyz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@smith-xyz
Copy link
Copy Markdown
Contributor Author

/config

@smith-xyz
Copy link
Copy Markdown
Contributor Author

/agentic_review

@smith-xyz
Copy link
Copy Markdown
Contributor Author

/hold

waiting to see why this wasn't triggered

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@smith-xyz
Copy link
Copy Markdown
Contributor Author

/agentic_review

@qodo-for-rh-openshift
Copy link
Copy Markdown

qodo-for-rh-openshift Bot commented May 19, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Push-triggered review churn ✓ Resolved 🐞 Bug ➹ Performance
Description
handle_push_trigger = true with push_commands = ["/agentic_review"] will cause the agent to
re-run on every push to a PR branch. This can create repeated comment updates and unnecessary
compute/API usage (amplified by persistent_comment = true).
Code

.pr_agent.toml[R1-5]

+[github_app]
+feedback_or_draft_pr = false
+handle_push_trigger = true
+pr_commands = ["/agentic_review"]
+push_commands = ["/agentic_review"]
Evidence
The config explicitly enables push triggers and assigns /agentic_review to run on push events; the
same file enables persistent comments which increases PR comment churn from repeated executions.

.pr_agent.toml[1-5]
.pr_agent.toml[20-28]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR agent is configured to run `/agentic_review` on *push* events (`handle_push_trigger=true` + `push_commands=["/agentic_review"]`). This will re-trigger reviews on every pushed commit, which is typically noisy and can consume extra API/compute.

## Issue Context
The same config also enables `persistent_comment = true`, which means repeated runs are likely to keep updating the PR’s persistent summary comment.

## Fix Focus Areas
- .pr_agent.toml[1-5]
- .pr_agent.toml[20-28]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Advisory comments

2. Undocumented agent config ✓ Resolved 🐞 Bug ⚙ Maintainability
Description
The repo documents Prow-based CI but does not document how/when this new PR-agent GitHub-app
configuration is expected to be used. This makes the config easy to misinterpret or become stale
because its operational owner and trigger model aren’t captured in-repo.
Code

.pr_agent.toml[R1-37]

+[github_app]
+feedback_or_draft_pr = false
+handle_push_trigger = true
+pr_commands = ["/agentic_review"]
+push_commands = ["/agentic_review"]
+
+[auto_best_practices]
+enable_auto_best_practices = true
+utilize_auto_best_practices = true
+
+[checks]
+enable_auto_checks_feedback = false
+
+[config]
+publish_output_progress = false
+
+[pr_code_suggestions]
+enable_chat_in_code_suggestions = true
+
+[review_agent]
+enabled = true
+approve_pr_on_self_review = false
+comments_location_policy = "summary"
+demand_self_review = true
+final_update_message = false
+persistent_comment = true
+persistent_comment_notification = false
+publish_output = true
+
+[review_agent_ux]
+finding_overflow_count = "all"
+expand_description = true
+expand_code = false
+expand_relevance = false
+expand_evidence = false
+expand_prompt = true
+resolved_overflow_count = "none"
Evidence
AGENTS.md describes CI being run via Prow/openshift-release config, while the PR introduces a
GitHub-app agent config file without any corresponding mention in that CI documentation.

AGENTS.md[37-40]
.pr_agent.toml[1-37]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A GitHub-app config file (`.pr_agent.toml`) was added, but there is no in-repo documentation describing its intended usage, ownership, or how it fits alongside the repo’s existing CI (documented as Prow-based).

## Issue Context
Without documentation, maintainers may not know whether this file is expected to be active in this repo, what triggers are intended (PR comment vs push), or how to change it safely.

## Fix Focus Areas
- AGENTS.md[37-40]
- .pr_agent.toml[1-37]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@smith-xyz
Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 19, 2026

@smith-xyz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant