CNF-23975: Rename v1 import alias to corev1 for k8s.io/api/core/v1#67
CNF-23975: Rename v1 import alias to corev1 for k8s.io/api/core/v1#67sebrandon1 wants to merge 1 commit into
Conversation
Align with existing import alias conventions (configv1, metav1) across 4 production files and 3 test files.
|
@sebrandon1: This pull request references CNF-23975 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
v1import alias tocorev1fork8s.io/api/core/v1across all filesconfigv1,metav1,operatorv1Jira: CNF-23975
Files changed (7)
Production:
internal/k8s/types.go,component.go,discovery.go,process.goTests:
internal/k8s/component_test.go,discovery_test.go,internal/scanner/scanner_test.goSimilar to
Test plan
go build ./...passesgo test ./...passesgrep -rn 'v1 "k8s.io/api/core/v1"'returns zero matches