Skip to content

CNF-23975: Rename v1 import alias to corev1 for k8s.io/api/core/v1#67

Open
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:rename-corev1-import
Open

CNF-23975: Rename v1 import alias to corev1 for k8s.io/api/core/v1#67
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:rename-corev1-import

Conversation

@sebrandon1
Copy link
Copy Markdown
Member

@sebrandon1 sebrandon1 commented May 18, 2026

Summary

  • Rename the v1 import alias to corev1 for k8s.io/api/core/v1 across all files
  • Aligns with existing conventions: configv1, metav1, operatorv1
  • Pure rename — no logic changes

Jira: CNF-23975

Files changed (7)

Production: internal/k8s/types.go, component.go, discovery.go, process.go
Tests: internal/k8s/component_test.go, discovery_test.go, internal/scanner/scanner_test.go

Similar to

Test plan

  • go build ./... passes
  • go test ./... passes
  • grep -rn 'v1 "k8s.io/api/core/v1"' returns zero matches

Align with existing import alias conventions (configv1, metav1) across
4 production files and 3 test files.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 18, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 18, 2026

@sebrandon1: This pull request references CNF-23975 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Rename the v1 import alias to corev1 for k8s.io/api/core/v1 across all files
  • Aligns with existing conventions: configv1, metav1, operatorv1
  • Pure rename — no logic changes

Jira: CNF-23975

Files changed (7)

Production: internal/k8s/types.go, component.go, discovery.go, process.go
Tests: internal/k8s/component_test.go, discovery_test.go, internal/scanner/scanner_test.go

Test plan

  • go build ./... passes
  • go test ./... passes
  • grep -rn 'v1 "k8s.io/api/core/v1"' returns zero matches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign rhmdnd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants