fix: dedup and assemble scan job results based on pod namespace and name too#65
Conversation
|
I will squash the commits before the final approval. Keeping it separated to make following the changes easier. |
openshift-ci
Bot
added
lgtm
|
let me know if you can rebase and can merge this in |
…ame too Pods that share the same host network (hostNetwork=true) see the same list of ports. The current dedup and assemle code picks pods with the first unique IP it sees and ignores every other pod. Even though ports on the same host network are owned by different pods. Which makes the final results claim a port owned by a different pod.
ingvagabund
force-pushed
the
shared-hosted-network-dedup-assemble-fix
branch
from
c4cd486 to
311b637
Compare
openshift-ci
Bot
removed
lgtm
|
Rebased and squashed |
|
@ingvagabund: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, smith-xyz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Pods that share the same host network (hostNetwork=true) see the same list of ports. The current dedup and assemle code picks pods with the first unique IP it sees and ignores every other pod. Even though ports on the same host network are owned by different pods. Which makes the final results claim a port owned by a different pod.
Fixes: #62