-
Notifications
You must be signed in to change notification settings - Fork 96
Update langchain dependencies to current versions #3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bump minimum version constraints for langchain ecosystem packages to address security vulnerabilities and ensure compatibility. This is largely due to https://nvd.nist.gov/vuln/detail/CVE-2025-68665, but Sippy in prod is already running non-vulernable versions (and is protected by auth anyway). This updated isn't strictly required, as we're rebuilding the Sippy container image at least once a day and pulling in updated packages. I'm not sure if we should be using requirements.lock for reproducible builds, but so far we're not really getting any severe breaking changes, and we are getting CVE fixes automatically. At least we set the right floor in requirements.txt.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
WalkthroughThis pull request upgrades multiple langchain-related dependencies to higher minimum versions in the chat/requirements.txt file and adds new dependencies including pydantic, httpx, and typing-extensions. The langchain-mcp-adapters package is pinned to version >=0.2.1. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (7 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
chat/requirements.txt (1)
15-16: Minor: Unpinned dependencies lack version constraints.Lines 15-16 specify
watchfilesandwebsocketswithout any version constraints. While the PR description notes that the Sippy container is rebuilt daily and pulls updated packages, this approach can lead to subtle incompatibilities if major versions introduce breaking changes. Consider adding minimum version constraints to these packages (e.g.,watchfiles>=0.20.0,websockets>=12.0.0) to improve reproducibility and reduce variability across environments.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
chat/requirements.txt
🔇 Additional comments (2)
chat/requirements.txt (2)
1-1: Approved: langchain ecosystem packages with appropriate minimum versions.The remaining langchain ecosystem packages have sensible minimum version constraints aligned with recent stable releases. langchain-core>=1.2.5 correctly addresses CVE-2025-68664, and the other packages (langgraph, langchain-openai, langchain-google-genai, langchain-community) have reasonable version floors.
Also applies to: 3-6
17-17: Approved: langchain-mcp-adapters pinned appropriately.The explicit pin to
langchain-mcp-adapters>=0.2.1is appropriate for this newer ecosystem package.
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
@stbenjam: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bump minimum version constraints for langchain ecosystem packages to address security vulnerabilities and ensure compatibility.
This is largely due to https://nvd.nist.gov/vuln/detail/CVE-2025-68665, but Sippy in prod is already running non-vulernable versions (and is protected by auth anyway).
This updated isn't strictly required, as we're rebuilding the Sippy container image at least once a day and pulling in updated packages. I'm not sure if we should be using requirements.lock for reproducible builds, but so far we're not really getting any severe breaking changes, and we are getting CVE fixes automatically. At least we set the right floor in requirements.txt.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.