Skip to content

MG-276: Changed OO_INSTALL_MODE to AllNamespaces#79691

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shivprakashmuley:fix-MG-276
May 26, 2026
Merged

MG-276: Changed OO_INSTALL_MODE to AllNamespaces#79691
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shivprakashmuley:fix-MG-276

Conversation

@shivprakashmuley
Copy link
Copy Markdown
Contributor

@shivprakashmuley shivprakashmuley commented May 26, 2026

Summary by CodeRabbit

This PR updates the must-gather-operator CI configuration across multiple OpenShift release branches to change the operator installation mode.

What changed:
The OO_INSTALL_MODE environment variable is being updated from OwnNamespace to AllNamespaces for three GCP-based end-to-end test workflows in the must-gather-operator CI configuration:

  • e2e-gcp-operator
  • e2e-gcp-operator-rhcos10-fips
  • e2e-gcp-operator-rhcos10

Affected versions:

  • Master branch
  • Release 4.21
  • Release 4.22
  • Release 4.23
  • Release 5.0
  • Release 5.1

Practical impact:
This changes how the must-gather-operator is installed during GCP end-to-end tests. The AllNamespaces mode enables the operator to watch and manage resources across all namespaces in the cluster, whereas OwnNamespace mode restricts it to a single namespace. This is a configuration-only change affecting the CI test infrastructure, with no changes to the operator code itself or any exported/public entity declarations.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 26, 2026

@shivprakashmuley: This pull request references MG-276 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026
@openshift-ci openshift-ci Bot requested review from Tafhim and ravitri May 26, 2026 07:40
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c66a8502-eea3-4d20-9a6f-2f0cce3444ba

📥 Commits

Reviewing files that changed from the base of the PR and between 3e488d3 and 5d3f479.

📒 Files selected for processing (6)
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-master.yaml
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.21.yaml
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.23.yaml
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-5.0.yaml
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-5.1.yaml

Walkthrough

The pull request updates the operator installation mode for must-gather-operator GCP-based end-to-end tests from OwnNamespace to AllNamespaces across the master branch and release branches 4.21 through 5.1.

Changes

Operator Install Mode Configuration

Layer / File(s) Summary
Master branch GCP e2e operator test configuration
ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-master.yaml
The three GCP e2e operator test steps (e2e-gcp-operator, e2e-gcp-operator-rhcos10-fips, e2e-gcp-operator-rhcos10) update OO_INSTALL_MODE from OwnNamespace to AllNamespaces.
Release 4.x branch GCP e2e operator test configurations
ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.*.yaml
Release branches 4.21, 4.22, and 4.23 consistently apply the OO_INSTALL_MODE change from OwnNamespace to AllNamespaces to the same three GCP e2e operator test steps.
Release 5.x branch GCP e2e operator test configurations
ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-5.*.yaml
Release branches 5.0 and 5.1 apply the same OO_INSTALL_MODE change from OwnNamespace to AllNamespaces to the three GCP e2e operator test steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/release#79324: Fixes the operator-sdk command script to pass OO_INSTALL_MODE via --install-mode, enabling the configuration changes in this PR to take effect.

Suggested labels

lgtm, approved

Suggested reviewers

  • tiraboschi
  • orenc1
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and specifically describes the main change: updating OO_INSTALL_MODE to AllNamespaces across multiple CI operator configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI/CD config files (YAML), not Ginkgo test code. No Ginkgo test definitions are present in the changed files. Check not applicable to CI configuration changes.
Test Structure And Quality ✅ Passed PR modifies only YAML CI/CD configuration files (openshift/must-gather-operator configs), not Ginkgo test code. The custom check for Ginkgo test quality is not applicable.
Microshift Test Compatibility ✅ Passed The PR modifies CI operator configuration YAML files only, changing OO_INSTALL_MODE settings. No new Ginkgo e2e tests are added, so the MicroShift Test Compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests; it only modifies CI configuration YAML files to change OO_INSTALL_MODE settings. The check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI operator configuration files, not deployment manifests or operator code, and introduces no scheduling constraints or topology-related configurations.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML CI operator configuration changes (OO_INSTALL_MODE updates), no Go source code modifications; OTE Binary Stdout Contract check is not applicable to configuration-only changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI operator config YAML files; no new Ginkgo e2e tests are added, so IPv6/disconnected network compatibility check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@shivprakashmuley: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-must-gather-operator-master-e2e-gcp-operator openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-master-e2e-gcp-operator-rhcos10 openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-master-e2e-gcp-operator-rhcos10-fips openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.23-e2e-gcp-operator openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.23-e2e-gcp-operator-rhcos10 openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.23-e2e-gcp-operator-rhcos10-fips openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-e2e-gcp-operator openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-e2e-gcp-operator-rhcos10 openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.22-e2e-gcp-operator-rhcos10-fips openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-5.0-e2e-gcp-operator openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-5.0-e2e-gcp-operator-rhcos10 openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-5.0-e2e-gcp-operator-rhcos10-fips openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-4.21-e2e-gcp-operator openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-5.1-e2e-gcp-operator openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-5.1-e2e-gcp-operator-rhcos10 openshift/must-gather-operator presubmit Ci-operator config changed
pull-ci-openshift-must-gather-operator-release-5.1-e2e-gcp-operator-rhcos10-fips openshift/must-gather-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Copy Markdown
Member

@swghosh swghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shivprakashmuley, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swghosh
Copy link
Copy Markdown
Member

swghosh commented May 26, 2026

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@swghosh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

@shivprakashmuley: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit f3c8ed4 into openshift:main May 26, 2026
14 checks passed
oharan2 pushed a commit to oharan2/release that referenced this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants