Skip to content

[DNM] Sync Serverless CI config/#79402

Open
maschmid wants to merge 1 commit into
openshift:mainfrom
maschmid:sync-serverless-ci
Open

[DNM] Sync Serverless CI config/#79402
maschmid wants to merge 1 commit into
openshift:mainfrom
maschmid:sync-serverless-ci

Conversation

@maschmid
Copy link
Copy Markdown
Contributor

@maschmid maschmid commented May 18, 2026

test only

Summary

This pull request synchronizes CI operator configuration for multiple OpenShift Knative projects by adding Slack reporter configurations to test jobs. The changes enable automated job status notifications to be posted to project-specific Slack channels.

Changes

The PR modifies CI job configurations across five Knative-related OpenShift projects:

  • eventing-istio (v1.17 and v1.21)
  • eventing-kafka-broker (v1.17 and v1.21)
  • eventing (v1.17 and v1.21)
  • serverless-operator (main with multiple configuration versions)
  • serving (v1.17 and v1.21)

For each project, reporter_config blocks are added to CI test job definitions, configuring:

  • Target Slack channels: #knative-eventing-ci for eventing projects, #serverless-ci for serverless-operator, and #knative-serving-ci for serving
  • Reported job states: success, failure, and error
  • Templated Slack messages that format differently based on job outcome and include links to job logs

The test jobs receiving these configurations follow the naming pattern *-c (e.g., test-e2e-c, test-conformance-c, test-reconciler-c) and vary by project and version.

Total impact: ~210 lines added across 10 configuration files with no removals.

Status: Marked as "DNM" (Do Not Merge) and labeled as test-only, indicating this is a draft/experimental change.

@maschmid
Copy link
Copy Markdown
Contributor Author

/hold

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cba73da3-bc00-4a34-b6a1-655ed2fac2cb

📥 Commits

Reviewing files that changed from the base of the PR and between c897a49 and f16704c.

⛔ Files ignored due to path filters (9)
  • ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (11)
  • ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__416.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__420.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421.yaml
  • ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__421.yaml

Walkthrough

This pull request adds Slack reporter configuration to CI job definitions across multiple Knative repositories. Each job now reports success, failure, and error states to the appropriate project-specific Slack channel with a templated message that includes the job name and a link to the logs.

Changes

Slack Reporter Configuration for CI Jobs

Layer / File(s) Summary
Eventing projects CI job reporting
ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yaml, ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21__421.yaml, ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yaml, ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__421.yaml, ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yaml, ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__421.yaml
Add reporter_config blocks to multiple test jobs (e2e-tests-c, test-conformance-c, test-e2e-c, test-encryption-auth-e2e-c, test-reconciler-c, test-reconciler-encryption-auth-c, test-reconciler-keda-c) across eventing projects, configuring Slack notifications to #knative-eventing-ci with conditional message templates for success vs failure/error states.
Serverless Operator CI job reporting
ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__416.yaml, ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__420.yaml, ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421.yaml
Add reporter_config blocks to multiple test variants (kitchensink-e2e-c, kitchensink-upgrade-c, mesh-e2e-c, operator-e2e-c, test-soak-c, test-upgrade-c, ui-e2e-c, upstream-e2e-kafka-c) across three workflow versions, configuring Slack notifications to #serverless-ci with conditional message templates including job logs links.
Serving project CI job reporting
ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__421.yaml, ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__421.yaml
Add reporter_config block to test-e2e-c job across serving release versions, configuring Slack notifications to #knative-serving-ci with conditional message templates that format success and failure/error states differently and include logs URL.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses '[DNM]' (do not merge) prefix and references 'Sync Serverless CI config/', which accurately reflects the PR's purpose of synchronizing CI configuration files for serverless operator and related projects.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR does not modify Ginkgo test code. Changes are to CI configuration YAML and utility test files using standard Go testing. Check for Ginkgo test name stability is not applicable.
Test Structure And Quality ✅ Passed This PR modifies only YAML CI configuration files with no Ginkgo test code. The custom check applies to Ginkgo test structure and quality, which are not present in this PR.
Microshift Test Compatibility ✅ Passed PR modifies CI configuration files only. No new Ginkgo test code (It(), Describe(), etc.) is added. Check applies only to new test code, not CI config.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only CI operator YAML configuration files, adding Slack notification settings. No new Ginkgo e2e tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI configuration files to add Slack reporter configs for test jobs. No deployment manifests, operator code, or scheduling constraints are added. Check not applicable.
Ote Binary Stdout Contract ✅ Passed PR only modifies 26 YAML CI configuration files. The OTE Binary Stdout Contract check applies to executable test binaries, not CI configuration. Not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only CI/CD job configuration files (YAML), not Ginkgo e2e test code. No new tests are added, only reporting configuration for existing jobs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2026
@openshift-ci openshift-ci Bot requested review from Cali0707 and aliok May 18, 2026 10:42
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maschmid
Once this PR has been reviewed and has the lgtm label, please assign creydr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@maschmid: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-knative-serverless-operator-main-421-operator-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-upstream-e2e-kafka-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-encryption-auth-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.21-421-test-reconciler-keda-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-kitchensink-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-test-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-conformance-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-ui-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.17-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-mesh-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.21-421-test-reconciler-encryption-auth-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-operator-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-upstream-e2e-kafka-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serving-release-v1.17-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.21-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-420-kitchensink-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.21-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-ui-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.17-421-test-encryption-auth-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-test-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-test-soak-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-istio-release-v1.17-421-e2e-tests-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.17-421-test-conformance-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-istio-release-v1.21-421-e2e-tests-c N/A periodic Ci-operator config changed

A total of 37 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

@maschmid: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant