Skip to content

Sync Serverless CI config/#79401

Open
serverless-qe wants to merge 1 commit into
openshift:mainfrom
serverless-qe:sync-serverless-ci
Open

Sync Serverless CI config/#79401
serverless-qe wants to merge 1 commit into
openshift:mainfrom
serverless-qe:sync-serverless-ci

Conversation

@serverless-qe
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 022e19c8-a1ff-47b6-ba02-e3f7bb7dc17b

📥 Commits

Reviewing files that changed from the base of the PR and between c897a49 and c685fd4.

⛔ Files ignored due to path filters (9)
  • ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/eventing/openshift-knative-eventing-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.17-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.21-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (11)
  • ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.21__421.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__416.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__420.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__421.yaml
  • ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__421.yaml
  • ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.21__421.yaml

Walkthrough

This PR systematically adds Slack job-state reporting configuration (reporter_config) to e2e and conformance test jobs across five Knative product lines: eventing-istio, eventing-kafka-broker, eventing, serverless-operator, and serving. Each configuration specifies a product-specific Slack channel, declares which job states (success, failure, error) to report, and defines a templated notification message with conditional formatting and log link inclusion.

Changes

CI Reporter Configuration Updates

Layer / File(s) Summary
eventing-istio reporter config
ci-operator/config/openshift-knative/eventing-istio/openshift-knative-eventing-istio-release-v1.17__421.yaml, openshift-knative-eventing-istio-release-v1.21__421.yaml
Adds reporter_config to e2e-tests-c test job in both v1.17 and v1.21 releases, reporting job states to #knative-eventing-ci with a templated message that conditionally formats success vs non-success outcomes and includes a log link.
eventing-kafka-broker reporter config
ci-operator/config/openshift-knative/eventing-kafka-broker/openshift-knative-eventing-kafka-broker-release-v1.17__421.yaml, openshift-knative-eventing-kafka-broker-release-v1.21__421.yaml
Adds reporter_config to multiple test jobs (conformance, e2e, reconciler, and reconciler variants) in both releases, reporting to #knative-eventing-ci with consistent channel, state filters, and templated Slack message formatting.
eventing reporter config
ci-operator/config/openshift-knative/eventing/openshift-knative-eventing-release-v1.17__421.yaml, openshift-knative-eventing-release-v1.21__421.yaml
Adds reporter_config to conformance, e2e, encryption-auth e2e, and reconciler test jobs in both releases, reporting job state changes to #knative-eventing-ci with state-conditional message templates and log link references.
serverless-operator reporter config
ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-main__416.yaml, openshift-knative-serverless-operator-main__420.yaml, openshift-knative-serverless-operator-main__421.yaml
Adds reporter_config to eight test job variants (kitchensink e2e and upgrade, mesh e2e, operator e2e, soak, upgrade, UI e2e, and upstream Kafka e2e) across three release configurations, reporting to #serverless-ci with consistent state reporting and templated message formatting.
serving reporter config
ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.17__421.yaml, openshift-knative-serving-release-v1.21__421.yaml
Adds reporter_config to test-e2e-c test job in both releases, reporting to #knative-serving-ci with job state filtering and a templated notification message that formats success vs failure outcomes differently.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • jmguzik
  • psalajova
🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Sync Serverless CI config/' is vague and overly broad, failing to clearly communicate the specific changes being made across multiple configuration files. Revise the title to be more specific and descriptive, such as 'Add reporter_config for Slack notifications to CI jobs' or 'Configure CI job state reporting across Knative projects'.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI operator YAML configuration files, not Ginkgo test code. No test name declarations with dynamic values present.
Test Structure And Quality ✅ Passed The custom check is designed to review Ginkgo test code quality. This PR contains only YAML CI operator configuration file changes with no Ginkgo tests. The check is not applicable.
Microshift Test Compatibility ✅ Passed PR adds no new Ginkgo e2e tests. All changes are CI YAML configuration only (reporter_config blocks). MicroShift check applies only to new tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added. The PR only modifies CI configuration YAML files to add reporter_config blocks for Slack reporting on existing test jobs. Check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI operator configuration (reporter_config for Slack reporting). No deployment manifests, operator code, or scheduling constraints present. Check not applicable.
Ote Binary Stdout Contract ✅ Passed PR contains no OTE binary code changes. Changes are YAML CI configs and utility scripts in hack/ directory, not part of openshift-tests. OTE Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI configuration YAML files adding reporter_config blocks. No Ginkgo e2e tests are added, so IPv6/disconnected network compatibility check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 18, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

Hi @serverless-qe. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from Cali0707 and aliok May 18, 2026 10:39
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-keda-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serving-release-v1.21-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-kitchensink-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-test-soak-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.21-421-test-encryption-auth-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-upstream-e2e-kafka-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-mesh-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.17-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.21-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-operator-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-kitchensink-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-upstream-e2e-kafka-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.21-421-test-reconciler-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.17-421-test-encryption-auth-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-420-kitchensink-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-release-v1.21-421-test-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-test-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-test-upgrade-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-istio-release-v1.21-421-e2e-tests-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-conformance-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-operator-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.17-421-test-reconciler-encryption-auth-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-416-mesh-e2e-c N/A periodic Ci-operator config changed
periodic-ci-openshift-knative-serverless-operator-main-421-ui-e2e-c N/A periodic Ci-operator config changed

A total of 37 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@maschmid
Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2026
@maschmid
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@maschmid
Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 18, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maschmid, serverless-qe
Once this PR has been reviewed and has the lgtm label, please assign kaustubh-pande for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

@serverless-qe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants