Adding OCP versioned ROSA Gap Analysis jobs#79399
Conversation
WalkthroughCI configuration for the ROSA gap analysis job is refactored: inline nightly test configuration is removed from the main config, which now specifies global pod resource constraints; a new periodic configuration file is created with build root, image publishing, and five OpenShift version–specific nightly test jobs running ChangesCI Periodic Job Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ravitri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift-online/rosa-gap-analysis/openshift-online-rosa-gap-analysis-main__periodics.yaml (1)
17-66: 🏗️ Heavy liftPrefer step-registry workflows over inline container commands in periodic tests.
Lines 18-66 currently duplicate inline shell logic across five jobs. Please move this into a step-registry workflow/chain and pass only version-specific inputs per test to align with repo CI config standards and reduce drift risk.
As per coding guidelines,
CI configuration files should define build_root, images, tests (referencing step-registry workflows), promotion, and releases sections in ci-operator/config/<org>/<repo>/.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-gap-analysis/openshift-online-rosa-gap-analysis-main__periodics.yaml` around lines 17 - 66, The five inline periodic jobs (as: nightly-4-19, nightly-4-20, nightly-4-21, nightly-4-22, nightly-5-0) duplicate the same shell steps (mkdir artifact dir, set REPORT_DIR, export OPENSHIFT_VERSION, run ./scripts/gap-all.sh); extract those commands into a step-registry workflow (e.g., rosa-gap-analysis/gap-all) that accepts an OPENSHIFT_VERSION input and performs the artifact setup and ./scripts/gap-all.sh run, then update each periodic test to call that workflow with only the version-specific input (OPENSHIFT_VERSION) instead of inline commands; also ensure the repository's ci-operator config follows guidelines by defining build_root, images, tests (pointing to the new step-registry workflow), promotion, and releases sections so the new workflow is referenced correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-gap-analysis/openshift-online-rosa-gap-analysis-main__periodics.yaml`:
- Around line 17-66: The five inline periodic jobs (as: nightly-4-19,
nightly-4-20, nightly-4-21, nightly-4-22, nightly-5-0) duplicate the same shell
steps (mkdir artifact dir, set REPORT_DIR, export OPENSHIFT_VERSION, run
./scripts/gap-all.sh); extract those commands into a step-registry workflow
(e.g., rosa-gap-analysis/gap-all) that accepts an OPENSHIFT_VERSION input and
performs the artifact setup and ./scripts/gap-all.sh run, then update each
periodic test to call that workflow with only the version-specific input
(OPENSHIFT_VERSION) instead of inline commands; also ensure the repository's
ci-operator config follows guidelines by defining build_root, images, tests
(pointing to the new step-registry workflow), promotion, and releases sections
so the new workflow is referenced correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: dbecfdbe-e2f8-43ab-aa22-31b45337dd66
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-online/rosa-gap-analysis/openshift-online-rosa-gap-analysis-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-online/rosa-gap-analysis/openshift-online-rosa-gap-analysis-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift-online/rosa-gap-analysis/openshift-online-rosa-gap-analysis-main.yamlci-operator/config/openshift-online/rosa-gap-analysis/openshift-online-rosa-gap-analysis-main__periodics.yaml
💤 Files with no reviewable changes (1)
- ci-operator/config/openshift-online/rosa-gap-analysis/openshift-online-rosa-gap-analysis-main.yaml
|
@ravitri: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Based on SREP-4811, we need to create OCP version based Gap Analysis jobs which would run the existing Gap Analysis automation over all OCP versions on a nightly basis.
Once done, will update rosa-e2e and Sippy as well.
Summary
This PR adds OCP-version-specific ROSA Gap Analysis periodic CI jobs. The changes configure nightly scheduled test jobs that run the existing Gap Analysis automation across multiple OCP versions (4.19, 4.20, 4.21, 4.22, and 5.0) per SREP-4811.
Changes
The PR modifies the CI configuration for the
openshift-online/rosa-gap-analysisrepository:Updated main configuration (
openshift-online-rosa-gap-analysis-main.yaml): Removed prowgen-specific settings and updated resource specifications for job pods.New periodic job definitions (
openshift-online-rosa-gap-analysis-main__periodics.yaml): Introduced a new CI periodic job variant that defines five nightly-scheduled test jobs (nightly-4-19throughnightly-5-0). Each job:./scripts/gap-all.sh)OPENSHIFT_VERSIONenvironment variable for the respective OCP versionrosa-gap-analysiscontainer imageThe configuration also includes a containerized build setup using
ci/Containerfileand establishes resource requests and limits for all job variants.Impact
Gap Analysis testing for ROSA is now automated across all active OCP versions on a nightly cadence, enabling continuous validation of ROSA compatibility across version releases.