Refactor NROP

[eifrach]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@eifrach has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 42 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 73c7b9ae-1498-4438-ace3-87fdac4f30be

📥 Commits

Reviewing files that changed from the base of the PR and between db07e0c and b87deba.

📒 Files selected for processing (1)

• ci-operator/step-registry/telcov10n/functional/compute-nrop/ocp-deploy/telcov10n-functional-compute-nrop-ocp-deploy-commands.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/telcov10n/functional/compute-nrop/ocp-deploy/OWNERS [eifrach]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@eifrach: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-20	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-19	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-14	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-18	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-20	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-18	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-21	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-19	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-16	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-14	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-nightly-compute-nrop-e2e-telcov10n-nrop-tests-4.22-nightly	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-stage-4-21	N/A	periodic	Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-16	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[eifrach]

/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-20

[openshift-merge-bot]

@eifrach: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@eifrach: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-20	b87deba	link	unknown	/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-compute-nrop-e2e-telcov10n-nrop-tests-prod-4-20

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.