Skip to content

OCPBUGS-85695: Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG#79388

Open
HarshwardhanPatil07 wants to merge 1 commit into
openshift:mainfrom
HarshwardhanPatil07:fix-rhcos9-upgrade-ip-stack
Open

OCPBUGS-85695: Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG#79388
HarshwardhanPatil07 wants to merge 1 commit into
openshift:mainfrom
HarshwardhanPatil07:fix-rhcos9-upgrade-ip-stack

Conversation

@HarshwardhanPatil07
Copy link
Copy Markdown
Contributor

@HarshwardhanPatil07 HarshwardhanPatil07 commented May 18, 2026

The jobs e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview and e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview override DEVSCRIPTS_CONFIG without including the workflow's settings. ci-operator replaces env vars entirely rather than merging, so IP_STACK=v4, NETWORK_TYPE, MASTER_DISK, and WORKER_DISK from the baremetalds-e2e-upgrade-ovn-ipv4 workflow were silently dropped, causing dev-scripts to default to IPv6.

Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG

Restores missing IPv4 stack settings in the OpenShift CI configuration for RHCOS 9 bare metal upgrade jobs.

Problem

Two RHCOS 9 bare metal iPI OVN upgrade jobs (e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview and e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview) inadvertently dropped workflow environment settings when overriding DEVSCRIPTS_CONFIG. Because ci-operator replaces environment variables wholesale rather than merging them, these job-level overrides removed critical settings inherited from the baremetalds-e2e-upgrade-ovn-ipv4 workflow, including IP_STACK=v4, NETWORK_TYPE, MASTER_DISK, and WORKER_DISK. This caused dev-scripts to default to IPv6 instead of the intended IPv4 configuration.

Solution

Updates the job definitions in the nightly 5.0 OpenShift release CI configuration to include the complete DEVSCRIPTS_CONFIG block with all necessary parameters: IP_STACK=v4, NETWORK_TYPE=OVNKubernetes, MASTER_DISK=80, and WORKER_DISK=80. This ensures these jobs retain the proper IPv4 network stack configuration when overriding the environment variable.

File changed: ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

The jobs e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview and
e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview override
DEVSCRIPTS_CONFIG without including the workflow's settings.
ci-operator replaces env vars entirely rather than merging, so
IP_STACK=v4, NETWORK_TYPE, MASTER_DISK, and WORKER_DISK from the
baremetalds-e2e-upgrade-ovn-ipv4 workflow were silently dropped,
causing dev-scripts to default to IPv6.

Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 99befbe9-6f0b-4fbb-916a-ab82f3668562

📥 Commits

Reviewing files that changed from the base of the PR and between 6cf3509 and a037ef3.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

Walkthrough

Extended the DEVSCRIPTS_CONFIG environment variable for two metal iPI OVN upgrade techpreview jobs (e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview and e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview) to specify IPv4 stack configuration, OVN network type, and disk sizing parameters.

Changes

Metal iPI OVN Upgrade Configuration

Layer / File(s) Summary
DEVSCRIPTS_CONFIG parameters for OVN upgrade jobs
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
Both techpreview jobs receive identical DEVSCRIPTS_CONFIG additions: IP_STACK=v4, NETWORK_TYPE=OVNKubernetes, MASTER_DISK=80, and WORKER_DISK=80.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm, rehearsals-ack

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the main change: adding missing IP_STACK=v4 configuration to RHCOS 9 upgrade jobs. It is specific, concise, and directly reflects the primary purpose of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Custom check is not applicable. PR modifies only CI/CD configuration YAML, not test code. No Ginkgo test definitions or test names are present in the changes.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test structure and quality is not applicable to this PR. The PR only modifies a YAML CI/CD configuration file, not test code.
Microshift Test Compatibility ✅ Passed PR modifies CI configuration (YAML) only, not new Ginkgo e2e tests. MicroShift Test Compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies CI-operator YAML configuration files and does not add any Ginkgo e2e tests. The custom check applies only when new Ginkgo tests are added, making it not applicable to this PR.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only CI test job configuration, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract checks Go test binaries. This PR only modifies YAML CI configuration with environment variables, containing no Go code changes. Check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Check not applicable. PR only modifies CI job configuration (YAML) and adds no new Ginkgo tests. Custom check applies only when new test code is added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from neisw and petr-muller May 18, 2026 04:55
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HarshwardhanPatil07
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HarshwardhanPatil07
Copy link
Copy Markdown
Contributor Author

/retitle OCPBUGS-85695: Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG

@openshift-ci openshift-ci Bot changed the title Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG OCPBUGS-85695: Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG May 18, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@HarshwardhanPatil07: This pull request references Jira Issue OCPBUGS-85695, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The jobs e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview and e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview override DEVSCRIPTS_CONFIG without including the workflow's settings. ci-operator replaces env vars entirely rather than merging, so IP_STACK=v4, NETWORK_TYPE, MASTER_DISK, and WORKER_DISK from the baremetalds-e2e-upgrade-ovn-ipv4 workflow were silently dropped, causing dev-scripts to default to IPv6.

Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG

Restores missing IPv4 stack settings in the OpenShift CI configuration for RHCOS 9 bare metal upgrade jobs.

Problem

Two RHCOS 9 bare metal iPI OVN upgrade jobs (e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview and e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview) inadvertently dropped workflow environment settings when overriding DEVSCRIPTS_CONFIG. Because ci-operator replaces environment variables wholesale rather than merging them, these job-level overrides removed critical settings inherited from the baremetalds-e2e-upgrade-ovn-ipv4 workflow, including IP_STACK=v4, NETWORK_TYPE, MASTER_DISK, and WORKER_DISK. This caused dev-scripts to default to IPv6 instead of the intended IPv4 configuration.

Solution

Updates the job definitions in the nightly 5.0 OpenShift release CI configuration to include the complete DEVSCRIPTS_CONFIG block with all necessary parameters: IP_STACK=v4, NETWORK_TYPE=OVNKubernetes, MASTER_DISK=80, and WORKER_DISK=80. This ensures these jobs retain the proper IPv4 network stack configuration when overriding the environment variable.

File changed: ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@HarshwardhanPatil07: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@HarshwardhanPatil07
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@HarshwardhanPatil07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@HarshwardhanPatil07
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@HarshwardhanPatil07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

@HarshwardhanPatil07: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview a037ef3 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview a037ef3 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants