OCPBUGS-85695: Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG#79388
OCPBUGS-85695: Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG#79388HarshwardhanPatil07 wants to merge 1 commit into
Conversation
The jobs e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview and e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview override DEVSCRIPTS_CONFIG without including the workflow's settings. ci-operator replaces env vars entirely rather than merging, so IP_STACK=v4, NETWORK_TYPE, MASTER_DISK, and WORKER_DISK from the baremetalds-e2e-upgrade-ovn-ipv4 workflow were silently dropped, causing dev-scripts to default to IPv6. Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughExtended the ChangesMetal iPI OVN Upgrade Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HarshwardhanPatil07 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retitle OCPBUGS-85695: Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG |
|
@HarshwardhanPatil07: This pull request references Jira Issue OCPBUGS-85695, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview |
|
@HarshwardhanPatil07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview |
|
@HarshwardhanPatil07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@HarshwardhanPatil07: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The jobs e2e-metal-ipi-ovn-upgrade-rhcos9-techpreview and e2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview override DEVSCRIPTS_CONFIG without including the workflow's settings. ci-operator replaces env vars entirely rather than merging, so IP_STACK=v4, NETWORK_TYPE, MASTER_DISK, and WORKER_DISK from the baremetalds-e2e-upgrade-ovn-ipv4 workflow were silently dropped, causing dev-scripts to default to IPv6.
Fix RHCOS 9 upgrade jobs missing IP_STACK=v4 in DEVSCRIPTS_CONFIG
Restores missing IPv4 stack settings in the OpenShift CI configuration for RHCOS 9 bare metal upgrade jobs.
Problem
Two RHCOS 9 bare metal iPI OVN upgrade jobs (
e2e-metal-ipi-ovn-upgrade-rhcos9-techpreviewande2e-metal-ipi-ovn-upgrade-rhcos9-10-techpreview) inadvertently dropped workflow environment settings when overridingDEVSCRIPTS_CONFIG. Because ci-operator replaces environment variables wholesale rather than merging them, these job-level overrides removed critical settings inherited from thebaremetalds-e2e-upgrade-ovn-ipv4workflow, includingIP_STACK=v4,NETWORK_TYPE,MASTER_DISK, andWORKER_DISK. This caused dev-scripts to default to IPv6 instead of the intended IPv4 configuration.Solution
Updates the job definitions in the nightly 5.0 OpenShift release CI configuration to include the complete
DEVSCRIPTS_CONFIGblock with all necessary parameters:IP_STACK=v4,NETWORK_TYPE=OVNKubernetes,MASTER_DISK=80, andWORKER_DISK=80. This ensures these jobs retain the proper IPv4 network stack configuration when overriding the environment variable.File changed:
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml