[Debug] Add wait step to opentelemetry-upstream-tests for OCP 4.22#79386
[Debug] Add wait step to opentelemetry-upstream-tests for OCP 4.22#79386IshwarKanse wants to merge 2 commits into
Conversation
Replaces distributed-tracing-tests-opentelemetry-upstream with wait step to enable SSH access for debugging test failures. TIMEOUT set to 10 hours. OCP Version: 4.22 Job: pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-4.22-amd64-opentelemetry-upstream-tests DO NOT MERGE — close this PR after debugging is complete.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Hidden review stack artifactWalkthroughThis PR updates an OpenShift CI workflow for the OpenTelemetry operator: it adds a ChangesOpenTelemetry Upstream Test Workflow Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IshwarKanse The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__upstream-ocp-4.22-amd64.yaml`:
- Line 141: The lane currently uses a placeholder ref ("ref: wait") which
replaces the real upstream test and can accidentally mark
opentelemetry-upstream-tests as green; restore a hard guard by either (A) adding
an intentional failure step after the wait (e.g., a terminating `fail` or `exit
1` equivalent) so the debug lane cannot be mistaken for a passing test, or (B)
isolate the debug lane by renaming it to a clearly temporary name (for example
prefix/suffix like "debug-...-TEMP" or "wip-...-DO-NOT-MERGE") and ensure it is
not referenced by gating/validation rules; target the entry that currently
contains the "ref: wait" and the lane id "opentelemetry-upstream-tests" when
making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 574bd66c-4cdf-469a-9390-cacc81c69c87
📒 Files selected for processing (1)
ci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__upstream-ocp-4.22-amd64.yaml
| memory: 400Mi | ||
| - ref: install-operators | ||
| - ref: distributed-tracing-tests-opentelemetry-upstream | ||
| - ref: wait |
There was a problem hiding this comment.
Avoid accidental false-green by replacing test execution with wait.
This change removes the actual upstream test ref from the lane, so a merge would turn opentelemetry-upstream-tests into a debug wait job instead of a validation signal. Please add a hard guard (for example, make the debug lane fail intentionally after wait or isolate it under a clearly temporary test name) to prevent accidental merge impact.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__upstream-ocp-4.22-amd64.yaml`
at line 141, The lane currently uses a placeholder ref ("ref: wait") which
replaces the real upstream test and can accidentally mark
opentelemetry-upstream-tests as green; restore a hard guard by either (A) adding
an intentional failure step after the wait (e.g., a terminating `fail` or `exit
1` equivalent) so the debug lane cannot be mistaken for a passing test, or (B)
isolate the debug lane by renaming it to a clearly temporary name (for example
prefix/suffix like "debug-...-TEMP" or "wip-...-DO-NOT-MERGE") and ensure it is
not referenced by gating/validation rules; target the entry that currently
contains the "ref: wait" and the lane id "opentelemetry-upstream-tests" when
making the change.
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@IshwarKanse: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-4.22-amd64-opentelemetry-upstream-tests |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 participant
Summary
distributed-tracing-tests-opentelemetry-upstreamref withwaitstep for debuggingpull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-4.22-amd64-opentelemetry-upstream-testsTIMEOUT: +10 hours)The wait step pauses the job before tests run, allowing SSH access to:
This PR modifies the OpenShift CI configuration for the open-telemetry/opentelemetry-operator repository to add a temporary debug pause and a longer timeout to the upstream OCP 4.22 test job.
What changed (practical effect)
Notes