Skip to content

HYPERFLEET-877 - ci: bump hyperfleet-hooks to v0.1.2#78645

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rafabene:HYPERFLEET-877-commitlint-sentinel
Apr 30, 2026
Merged

HYPERFLEET-877 - ci: bump hyperfleet-hooks to v0.1.2#78645
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
rafabene:HYPERFLEET-877-commitlint-sentinel

Conversation

@rafabene
Copy link
Copy Markdown
Contributor

@rafabene rafabene commented Apr 30, 2026

Summary

  • Blocker fix: v0.1.1 validates the entire repository history instead of only PR commits, causing validate-commits to fail on all PRs (e.g. hyperfleet-api#115)
  • Bump hyperfleet-hooks from v0.1.1 to v0.1.2 which replaces go-git linear walk with git rev-list to correctly compute the PR commit range
  • Replace go install (~3min compile) with pre-built binary download from GitHub releases (~2s)

Test plan

  • Fix validated with unit tests including diverged branch scenario
  • Verify via rehearsal that validate-commits passes on PRs

Summary by CodeRabbit

  • Chores
    • Switched CI tooling installation to use a prebuilt binary (v0.1.2) instead of building from source, improving pipeline reliability and reducing runtime/setup variability.
    • Simplified installation and PATH handling to speed CI steps and make commit-lint checks more consistent.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 43efd51e-847c-49fd-8060-72e62024b5d3

📥 Commits

Reviewing files that changed from the base of the PR and between 9d43dd0 and 1332918.

📒 Files selected for processing (1)
  • ci-operator/step-registry/hyperfleet/commitlint/hyperfleet-commitlint-commands.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/step-registry/hyperfleet/commitlint/hyperfleet-commitlint-commands.sh

Walkthrough

Replaced building hyperfleet-hooks via go install and custom Go env vars with downloading a prebuilt hyperfleet-hooks v0.1.2 binary into /tmp, making it executable, and adding /tmp to PATH before invoking hyperfleet-hooks commitlint --pr. (50 words)

Changes

Cohort / File(s) Summary
Commitlint script
ci-operator/step-registry/hyperfleet/commitlint/hyperfleet-commitlint-commands.sh
Replaced go install build/install (previously pinned v0.1.1) and custom Go cache/temp env setup with downloading prebuilt hyperfleet-hooks binary v0.1.2 to /tmp, chmod +x, and prepending /tmp to PATH. Invocation hyperfleet-hooks commitlint --pr unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: bumping the hyperfleet-hooks dependency version from v0.1.1 to v0.1.2 in the CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR contains no Ginkgo tests or test-related code changes. The only file modified is a bash shell script that downloads and executes a CI/CD validation tool. Since the custom check is specifically for ensuring Ginkgo test names are stable and deterministic, and this PR introduces no test names of any kind, the check is not applicable and passes by default.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable as the PR only modifies a bash shell script for CI/CD configuration and contains no Ginkgo test code.
Microshift Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests; it only updates a CI/CD shell script to switch from go install to downloading a prebuilt binary.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies a CI script to update tool versioning; no Ginkgo e2e tests are added or modified.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies a CI/CD shell script for commit linting, not deployment manifests, operator code, or controllers with topology-aware scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR modifies a shell script that orchestrates hyperfleet-hooks binary execution, not an OTE binary with process-level Go code that outputs JSON to stdout. This check does not apply to shell scripts.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only a CI operator shell script bumping hyperfleet-hooks from v0.1.1 to v0.1.2. No Ginkgo e2e tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 8/10 reviews remaining, refill in 11 minutes and 19 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@rafabene rafabene force-pushed the HYPERFLEET-877-commitlint-sentinel branch from 511046c to 9d43dd0 Compare April 30, 2026 14:12
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@rafabene rafabene changed the title HYPERFLEET-877 - ci: add commit message validation for hyperfleet-api HYPERFLEET-877 - ci: bump hyperfleet-hooks to v0.1.2 Apr 30, 2026
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2026
@openshift-ci openshift-ci Bot requested review from crizzo71 and ma-hill April 30, 2026 14:16
Replace go install (slow ~3min compile) with pre-built binary download
from GitHub releases (~2s). Also fixes PR commit range calculation to
only validate PR commits instead of the entire repository history.
@rafabene rafabene force-pushed the HYPERFLEET-877-commitlint-sentinel branch from 9d43dd0 to 1332918 Compare April 30, 2026 14:18
@rafabene
Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@rafabene: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rafabene: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hyperfleet-hyperfleet-sentinel-main-validate-commits openshift-hyperfleet/hyperfleet-sentinel presubmit Registry content changed
pull-ci-openshift-hyperfleet-hyperfleet-broker-main-validate-commits openshift-hyperfleet/hyperfleet-broker presubmit Registry content changed
pull-ci-openshift-hyperfleet-hyperfleet-api-main-validate-commits openshift-hyperfleet/hyperfleet-api presubmit Registry content changed
pull-ci-openshift-hyperfleet-hyperfleet-adapter-main-validate-commits openshift-hyperfleet/hyperfleet-adapter presubmit Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 30, 2026
@kuudori
Copy link
Copy Markdown
Contributor

kuudori commented Apr 30, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026
@rh-amarin
Copy link
Copy Markdown

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuudori, rafabene, rh-amarin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit fd627a0 into openshift:main Apr 30, 2026
14 checks passed
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
Replace go install (slow ~3min compile) with pre-built binary download
from GitHub releases (~2s). Also fixes PR commit range calculation to
only validate PR commits instead of the entire repository history.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants