Skip to content

DPTP-4755: Add several ServiceAccounts to core-ci#77358

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
liangxia:pj-rehearse-serviceaccount
Apr 3, 2026
Merged

DPTP-4755: Add several ServiceAccounts to core-ci#77358
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
liangxia:pj-rehearse-serviceaccount

Conversation

@liangxia
Copy link
Copy Markdown
Member

@liangxia liangxia commented Apr 3, 2026 •
edited
Loading

Add several ServiceAccounts to core-ci, mainly working on pj-rehearse, add the other SAs just to not break ci-secret-generator

The failures in job secret-generator-config-valid are expected. Those missing one are the ones that this PR mean to create.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 3, 2026 •
edited by atlassian bot
Loading

@liangxia: This pull request references DPTP-4755 which is a valid jira issue.

Details

In response to this:

Add several ServiceAccounts to core-ci, mainly working on pj-rehearse, add the other SAs just to not break ci-secret-generator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2026
@openshift-ci openshift-ci bot requested review from Prucek and bear-redhat April 3, 2026 04:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 3, 2026

[REHEARSALNOTIFIER]
@liangxia: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 3, 2026
@liangxia
Copy link
Copy Markdown
Member Author

liangxia commented Apr 3, 2026

/retest-required

@liangxia
Copy link
Copy Markdown
Member Author

liangxia commented Apr 3, 2026

/test secret-generator-config-valid

@liangxia
Copy link
Copy Markdown
Member Author

liangxia commented Apr 3, 2026

/cc @openshift/test-platform

@openshift-ci openshift-ci bot requested a review from a team April 3, 2026 06:12
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 3, 2026 •
edited by atlassian bot
Loading

@liangxia: This pull request references DPTP-4755 which is a valid jira issue.

Details

In response to this:

Add several ServiceAccounts to core-ci, mainly working on pj-rehearse, add the other SAs just to not break ci-secret-generator

The failures in job secret-generator-config-valid are expected. Those missing one are the ones that this PR mean to create.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 3, 2026 •
edited by atlassian bot
Loading

@liangxia: This pull request references DPTP-4755 which is a valid jira issue.

Details

In response to this:

Add several ServiceAccounts to core-ci, mainly working on pj-rehearse, add the other SAs just to not break ci-secret-generator

The failures in job secret-generator-config-valid are expected. Those missing one are the ones that this PR mean to create.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 3, 2026 •
edited by atlassian bot
Loading

@liangxia: This pull request references DPTP-4755 which is a valid jira issue.

Details

In response to this:

Add several ServiceAccounts to core-ci, mainly working on pj-rehearse, add the other SAs just to not break ci-secret-generator

The failures in job secret-generator-config-valid are expected. Those missing one are the ones that this PR mean to create.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liangxia
Copy link
Copy Markdown
Member Author

liangxia commented Apr 3, 2026

/override ci/prow/secret-generator-config-valid

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@liangxia: Overrode contexts on behalf of liangxia: ci/prow/secret-generator-config-valid

Details

In response to this:

/override ci/prow/secret-generator-config-valid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@liangxia: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danilo-gemoli
Copy link
Copy Markdown
Contributor

danilo-gemoli commented Apr 3, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cb73b86 into openshift:main Apr 3, 2026
22 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@liangxia: Updated the following 2 configmaps:

  • ci-secret-generator configmap in namespace ci at cluster app.ci using the following files:
    • key _config.yaml using file core-services/ci-secret-generator/_config.yaml
  • ci-secret-generator configmap in namespace ci at cluster core-ci using the following files:
    • key _config.yaml using file core-services/ci-secret-generator/_config.yaml
Details

In response to this:

Add several ServiceAccounts to core-ci, mainly working on pj-rehearse, add the other SAs just to not break ci-secret-generator

The failures in job secret-generator-config-valid are expected. Those missing one are the ones that this PR mean to create.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bear-redhat bear-redhat Awaiting requested review from bear-redhat

@Prucek Prucek Awaiting requested review from Prucek

Assignees

@danilo-gemoli danilo-gemoli

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liangxia @openshift-ci-robot @danilo-gemoli