Skip to content

Refactor cost-onprem-chart job config to avoid long running tests on PRs#77270

Open
testetson22 wants to merge 1 commit intoopenshift:mainfrom
testetson22:flpath-3369-fix-job-triggers
Open

Refactor cost-onprem-chart job config to avoid long running tests on PRs#77270
testetson22 wants to merge 1 commit intoopenshift:mainfrom
testetson22:flpath-3369-fix-job-triggers

Conversation

@testetson22
Copy link
Copy Markdown
Contributor

@testetson22 testetson22 commented Apr 1, 2026

  • Remove optional IQE test jobs (e2e-iqe-extended, e2e-iqe-stable, e2e-iqe-full) that were unintentionally triggering on PRs due to skip_if_only_changed misconfiguration. These will be enabled once supported. IQE changes are in the publish pipeline.
  • The main e2e job with IQE smoke tests continues to run on relevant code changes

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: testetson22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@openshift-ci openshift-ci bot requested review from jordigilh and masayag April 1, 2026 19:30
@testetson22
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@testetson22: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 1, 2026
@jordigilh
Copy link
Copy Markdown

Review feedback

1. Commit message is misleading

The commit message says:

"Removed skip_if_only_changed condition from presubmit jobs to ensure all changes trigger the tests."

This describes the opposite of what the PR does. With always_run: false and no skip_if_only_changed, the tests are never automatically triggered — they only run via explicit /test commands. Suggest amending to something like:

"Removed skip_if_only_changed condition from presubmit jobs; combined with always_run: false, these tests now only run when manually triggered via /test."

2. When should these be manually triggered?

After this change, extended/stable/full only run if someone remembers to /test them. Is there guidance (e.g., a PR template checklist, or a wiki page) on when contributors should trigger these? For example: before release cuts, after infra changes, etc. Without that, these tests could go un-triggered for long stretches.

3. Periodic/postsubmit coverage?

With presubmits now manual-only, is there a periodic or postsubmit job that runs these profiles against main? If not, a regression could land without anyone noticing until the next manual run.

@testetson22
Copy link
Copy Markdown
Contributor Author

testetson22 commented Apr 2, 2026

Review feedback

1. Commit message is misleading

The commit message says:

"Removed skip_if_only_changed condition from presubmit jobs to ensure all changes trigger the tests."

This describes the opposite of what the PR does. With always_run: false and no skip_if_only_changed, the tests are never automatically triggered — they only run via explicit /test commands. Suggest amending to something like:

Yes, the PR summary should have an accurate statement on this now; Claude generated an incorrect commit message that I did not catch.

"Removed skip_if_only_changed condition from presubmit jobs; combined with always_run: false, these tests now only run when manually triggered via /test."

2. When should these be manually triggered?

After this change, extended/stable/full only run if someone remembers to /test them. Is there guidance (e.g., a PR template checklist, or a wiki page) on when contributors should trigger these? For example: before release cuts, after infra changes, etc. Without that, these tests could go un-triggered for long stretches.

Never. Until IQE work I've previously discussed is merged. Once that is merged, they can be triggered nightly, ad-hoc, and maybe on PRs, but anything above the smoke profile may hit all of the aforementioned issues in the documentation and will just time out right now. I'll clarify any guidance when they're actually runnable. If anything, I'm going to delete the additional jobs to avoid confusion until everything is aligned.

3. Periodic/postsubmit coverage?

With presubmits now manual-only, is there a periodic or postsubmit job that runs these profiles against main? If not, a regression could land without anyone noticing until the next manual run.

e2e with IQE smoke profile still runs on PRs. The other profiles were not intended to be ran automatically until my fixes and enhancements to IQE are merged.

The e2e-iqe-extended, e2e-iqe-stable, and e2e-iqe-full jobs were
misconfigured with skip_if_only_changed, causing them to run
automatically on PRs with code changes instead of being on-demand.

Removing these jobs until they can be properly configured as
on-demand tests triggered only via /test commands.

The main e2e job (with IQE smoke profile) remains unchanged and
will continue to run on relevant code changes.

Made-with: Cursor
@testetson22 testetson22 force-pushed the flpath-3369-fix-job-triggers branch from 093efdf to 230c254 Compare April 2, 2026 14:10
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@testetson22: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@testetson22
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@testetson22: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@testetson22: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants