-
Notifications
You must be signed in to change notification settings - Fork 2.2k
AGENT-1486 AGENT-1487: Add generic iso-no-registry conformance workflow and test ref #77255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rwsu
wants to merge
2
commits into
openshift:main
Choose a base branch
from
rwsu:AGENT-1486-1487
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
ci-operator/step-registry/agent/e2e/generic/conformance/iso-no-registry/OWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| approvers: | ||
| - andfasano | ||
| - bfournie | ||
| - pamoedom | ||
| - pawanpinjarkar | ||
| - rwsu | ||
| - zaneb |
13 changes: 13 additions & 0 deletions
13
...ance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "path": "agent/e2e/generic/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "andfasano", | ||
| "bfournie", | ||
| "pamoedom", | ||
| "pawanpinjarkar", | ||
| "rwsu", | ||
| "zaneb" | ||
| ] | ||
| } | ||
| } |
16 changes: 16 additions & 0 deletions
16
...c/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| workflow: | ||
| as: agent-e2e-generic-conformance-iso-no-registry | ||
| steps: | ||
| allow_best_effort_post_steps: true | ||
| allow_skip_on_success: true | ||
| env: | ||
| DEVSCRIPTS_TARGET: agent | ||
| pre: | ||
| - chain: agent-pre | ||
| test: | ||
| - chain: agent-test-conformance-iso-no-registry | ||
| post: | ||
| - chain: agent-post | ||
| documentation: |- | ||
| This workflow is a generic conformance one to deploy a no registry cluster provisioned by running agent installer, and it | ||
| will require to set the env variable DEVSCRIPTS_CONFIG to work properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| approvers: | ||
| - andfasano | ||
| - bfournie | ||
| - pamoedom | ||
| - pawanpinjarkar | ||
| - rwsu | ||
| - zaneb |
7 changes: 7 additions & 0 deletions
7
ci-operator/step-registry/agent/e2e/test/iso-no-registry/OWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| approvers: | ||
| - andfasano | ||
| - bfournie | ||
| - pamoedom | ||
| - pawanpinjarkar | ||
| - rwsu | ||
| - zaneb |
24 changes: 24 additions & 0 deletions
24
...r/step-registry/agent/e2e/test/iso-no-registry/agent-e2e-test-iso-no-registry-commands.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -o nounset | ||
| set -o errexit | ||
| set -o pipefail | ||
|
|
||
| export KUBECONFIG=${SHARED_DIR}/kubeconfig | ||
|
|
||
| echo "$(date +%s)" > "${SHARED_DIR}/TEST_TIME_TEST_START" | ||
| trap 'echo "$(date +%s)" > "${SHARED_DIR}/TEST_TIME_TEST_END"' EXIT | ||
|
|
||
| TEST_ARGS="" | ||
|
|
||
| if [[ -n "${TEST_SKIPS:-}" ]]; then | ||
| TESTS="$(openshift-tests run all --dry-run)" | ||
| echo "${TESTS}" | grep -v "${TEST_SKIPS}" >/tmp/tests | ||
| echo "Skipping tests:" | ||
| echo "${TESTS}" | grep "${TEST_SKIPS}" || true | ||
| TEST_ARGS="--file /tmp/tests" | ||
| fi | ||
|
|
||
| openshift-tests run all --run ".*NoRegistryClusterInstall.*" ${TEST_ARGS} \ | ||
| -o "${ARTIFACT_DIR}/e2e.log" \ | ||
| --junit-dir "${ARTIFACT_DIR}/junit" | ||
13 changes: 13 additions & 0 deletions
13
...-registry/agent/e2e/test/iso-no-registry/agent-e2e-test-iso-no-registry-ref.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "path": "agent/e2e/test/iso-no-registry/agent-e2e-test-iso-no-registry-ref.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "andfasano", | ||
| "bfournie", | ||
| "pamoedom", | ||
| "pawanpinjarkar", | ||
| "rwsu", | ||
| "zaneb" | ||
| ] | ||
| } | ||
| } |
22 changes: 22 additions & 0 deletions
22
...ator/step-registry/agent/e2e/test/iso-no-registry/agent-e2e-test-iso-no-registry-ref.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| ref: | ||
| as: agent-e2e-test-iso-no-registry | ||
| from: tests | ||
| grace_period: 10m | ||
| commands: agent-e2e-test-iso-no-registry-commands.sh | ||
| timeout: 5h0m0s | ||
| resources: | ||
| requests: | ||
| cpu: "3" | ||
| memory: 600Mi | ||
| limits: | ||
| memory: 12Gi | ||
| env: | ||
| - name: TEST_SKIPS | ||
| default: "" | ||
| documentation: |- | ||
| Regular expression (POSIX basic regular expression) of tests to skip. | ||
| If unset, all NoRegistryClusterInstall origin tests are run. | ||
| documentation: |- | ||
| Runs the NoRegistryClusterInstall origin tests for the agent installer ISO NO REGISTRY | ||
| scenario. Exports the kubeconfig and runs openshift-tests without image mirroring, | ||
| optionally filtering out tests matching TEST_SKIPS. |
7 changes: 7 additions & 0 deletions
7
ci-operator/step-registry/agent/test/conformance/iso-no-registry/OWNERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| approvers: | ||
| - andfasano | ||
| - bfournie | ||
| - pamoedom | ||
| - pawanpinjarkar | ||
| - rwsu | ||
| - zaneb |
13 changes: 13 additions & 0 deletions
13
...st/conformance/iso-no-registry/agent-test-conformance-iso-no-registry-chain.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "path": "agent/test/conformance/iso-no-registry/agent-test-conformance-iso-no-registry-chain.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "andfasano", | ||
| "bfournie", | ||
| "pamoedom", | ||
| "pawanpinjarkar", | ||
| "rwsu", | ||
| "zaneb" | ||
| ] | ||
| } | ||
| } |
6 changes: 6 additions & 0 deletions
6
.../agent/test/conformance/iso-no-registry/agent-test-conformance-iso-no-registry-chain.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| chain: | ||
| as: agent-test-conformance-iso-no-registry | ||
| steps: | ||
| - ref: agent-e2e-test-iso-no-registry | ||
| documentation: |- | ||
| This chain encapsulates the e2e tests for the agent installer ISO No registry |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this cmd locally and it worked fine:
Not sure if in the CI env will still required OPENSHIFT_SKIP_EXTERNAL_TESTS=true (as I did locally)