AGENT-1486: Create generic ISO no registry workflow#77197
AGENT-1486: Create generic ISO no registry workflow#77197pawanpinjarkar wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@pawanpinjarkar: This pull request references AGENT-1486 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
I think we should add these common iso-no-registry dev-scripts env vars to the workflow definition:
| DEVSCRIPTS_TARGET: agent | |
| DEVSCRIPTS_CONFIG: | | |
| AGENT_E2E_TEST_BOOT_MODE=ISO_NO_REGISTRY | |
| AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV=true |
Would it be helpful to leave AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV unset and default to false to aid in debugging?
There was a problem hiding this comment.
Since they are going to be replaced in every usage, better to leave it empty
|
closed as handled via #77255 |
No description provided.