Skip to content

Add skip check for docs/CI only PRs | Disable e2e tests#77095

Closed
mynhardtburger wants to merge 9 commits intoopenshift:mainfrom
mynhardtburger:ci/prow/images_skip_if_only_changes
Closed

Add skip check for docs/CI only PRs | Disable e2e tests#77095
mynhardtburger wants to merge 9 commits intoopenshift:mainfrom
mynhardtburger:ci/prow/images_skip_if_only_changes

Conversation

@mynhardtburger
Copy link
Copy Markdown

@mynhardtburger mynhardtburger commented Mar 30, 2026 •
edited
Loading

  1. Disable e2e-test-maas job for rhaoi and stable branches.
    When always_run: false and no skip_if_only_changed / run_if_changed is set, the job is only triggerable manually.
    https://docs.prow.k8s.io/docs/jobs/#triggering-jobs

  2. Add skip check to the ci/prow/images pipeline to avoid running for docs/CI only PRs.
    This is the same skip check used for the other pipelines in this file.
    This is done directly in the generated jobs/* yaml as allowed per the documentation -> https://docs.ci.openshift.org/how-tos/contributing-openshift-release/#tolerated-changes-to-generated-jobs

@mynhardtburger
Add skip check for docs only PRs
aab9ada 
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci openshift-ci bot requested review from nerdalert and ryancham715 March 30, 2026 16:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 30, 2026

@mynhardtburger, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: job pull-ci-opendatahub-io-models-as-a-service-main-images is set to always run but also declares skip_if_only_changed targets, which are mutually exclusive
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mynhardtburger
Set always_run to false
76a52bd 
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 30, 2026
@chaitanya1731
Copy link
Copy Markdown
Contributor

chaitanya1731 commented Mar 30, 2026

While we are here, can you also update for rhoai and stable branches please?

@mynhardtburger
Add skip_if_only_changed condition to rhoai and stable branches as well.
7caa244 
Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@mynhardtburger
Disable e2e tests for rhoai and stable branches as they are being exe…
92c5c93 
…cuted in the konflux pipelines as well.

Signed-off-by: Mynhardt Burger <mynhardt@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 30, 2026
@mynhardtburger mynhardtburger changed the title Add skip check for docs/CI only PRs Add skip check for docs/CI only PRs | Disable e2e tests Mar 30, 2026
@chaitanya1731
Copy link
Copy Markdown
Contributor

chaitanya1731 commented Mar 30, 2026

/pj-rehearse auto-ack
/approve
/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 30, 2026

@chaitanya1731: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@mynhardtburger
Copy link
Copy Markdown
Author

mynhardtburger commented Mar 31, 2026

/retest-required

1 similar comment
@mynhardtburger
Copy link
Copy Markdown
Author

mynhardtburger commented Mar 31, 2026

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@chaitanya1731
Copy link
Copy Markdown
Contributor

chaitanya1731 commented Mar 31, 2026

/pj-rehearse auto-ack
/approve
/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@chaitanya1731: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaitanya1731, mynhardtburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mynhardtburger
Copy link
Copy Markdown
Author

mynhardtburger commented Apr 1, 2026

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 1, 2026

@mynhardtburger: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mynhardtburger
Copy link
Copy Markdown
Author

mynhardtburger commented Apr 1, 2026

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 2, 2026

[REHEARSALNOTIFIER]
@mynhardtburger: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-models-as-a-service-rhoai-e2e-test-maas opendatahub-io/models-as-a-service presubmit Ci-operator config changed
pull-ci-opendatahub-io-models-as-a-service-stable-e2e-test-maas opendatahub-io/models-as-a-service presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@mynhardtburger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config dbd38bd link true /test generated-config
ci/rehearse/opendatahub-io/models-as-a-service/stable/e2e-test-maas 0dfbdb8 link unknown /pj-rehearse pull-ci-opendatahub-io-models-as-a-service-stable-e2e-test-maas
ci/rehearse/opendatahub-io/models-as-a-service/rhoai/e2e-test-maas 0dfbdb8 link unknown /pj-rehearse pull-ci-opendatahub-io-models-as-a-service-rhoai-e2e-test-maas

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mynhardtburger
Copy link
Copy Markdown
Author

mynhardtburger commented Apr 2, 2026

Closing. Superceded by #77280

@mynhardtburger mynhardtburger deleted the ci/prow/images_skip_if_only_changes branch April 2, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nerdalert nerdalert Awaiting requested review from nerdalert

@ryancham715 ryancham715 Awaiting requested review from ryancham715

Assignees

@chaitanya1731 chaitanya1731

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mynhardtburger @openshift-ci-robot @chaitanya1731