Skip to content

Acquire install lease when provisioning a cluster 2#76958

Open
danilo-gemoli wants to merge 1 commit intoopenshift:mainfrom
danilo-gemoli:feat/ci-operator/acquire-install-lease-destroy-cluster-on-provision
Open

Acquire install lease when provisioning a cluster 2#76958
danilo-gemoli wants to merge 1 commit intoopenshift:mainfrom
danilo-gemoli:feat/ci-operator/acquire-install-lease-destroy-cluster-on-provision

Conversation

@danilo-gemoli
Copy link
Copy Markdown
Contributor

Continuation of #76238.
The ipi-install-install creates a cluster in a retry loop and, on iteration n, it destroys the cluster of the previous iteration n-1 before proceeding any further.
The openshift-install destroy cluster command should be made safe by acquiring an install lease as it has been done for openshift-install create cluster.

@openshift-ci openshift-ci bot requested review from smg247 and sosiouxme March 27, 2026 08:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2026
@jupierce
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, jupierce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danilo-gemoli
Copy link
Copy Markdown
Contributor Author

/pj-rehearse list

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@danilo-gemoli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danilo-gemoli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-configmap-reload-main-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-main-okd-scos-e2e-aws-ovn openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-5.0-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.23-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.22-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.21-okd-scos-e2e-aws-ovn openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.21-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.20-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.19-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.18-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.17-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.16-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.15-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.14-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.13-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.12-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.11-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.10-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.9-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.8-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.7-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-configmap-reload-release-4.6-e2e-aws openshift/configmap-reload presubmit Registry content changed
pull-ci-openshift-tls-scanner-main-default-tls openshift/tls-scanner presubmit Registry content changed
pull-ci-openshift-tls-scanner-release-5.0-default-tls openshift/tls-scanner presubmit Registry content changed
pull-ci-openshift-tls-scanner-release-4.23-default-tls openshift/tls-scanner presubmit Registry content changed

A total of 29200 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@danilo-gemoli
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-cri-o-cri-o-main-e2e-aws-ovn

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@danilo-gemoli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

@danilo-gemoli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/cri-o/cri-o/main/e2e-aws-ovn 30e013d link unknown /pj-rehearse pull-ci-cri-o-cri-o-main-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants