Skip to content

OTA-1764: CVO: Add an Optional TLS Scanner Presubmit Job#76044

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
DavidHurta:cvo-add-tls-scanner
Mar 17, 2026
Merged

OTA-1764: CVO: Add an Optional TLS Scanner Presubmit Job#76044
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
DavidHurta:cvo-add-tls-scanner

Conversation

@DavidHurta
Copy link
Contributor

@DavidHurta DavidHurta commented Mar 11, 2026 •
edited
Loading

To be used to verify openshift/cluster-version-operator#1338 changes.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2026
@openshift-ci openshift-ci bot requested review from fao89 and wking March 11, 2026 01:05
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Mar 11, 2026

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2026

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidHurta DavidHurta force-pushed the cvo-add-tls-scanner branch from e7be9bb to 6a0a818 Compare March 11, 2026 14:45
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 11, 2026
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Mar 11, 2026

/pj-rehearse ?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2026

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidHurta
Copy link
Contributor Author

DavidHurta commented Mar 11, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2026

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidHurta
Copy link
Contributor Author

DavidHurta commented Mar 11, 2026

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-tls-scanner

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2026

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidHurta DavidHurta force-pushed the cvo-add-tls-scanner branch from baf6449 to 817b0e9 Compare March 11, 2026 18:03
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 11, 2026
@DavidHurta
Copy link
Contributor Author

DavidHurta commented Mar 11, 2026

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-tls-scanner

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2026

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2026

@DavidHurta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-version-operator/main/e2e-agnostic-ovn e7be9bb link unknown /pj-rehearse pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DavidHurta DavidHurta force-pushed the cvo-add-tls-scanner branch from 817b0e9 to a01df69 Compare March 17, 2026 01:48
@DavidHurta DavidHurta changed the title WIP: CVO: Add the TLS scanner test step to the E2E presubmit job OTA-1764: CVO: Add an Optional TLS Scanner Presubmit Job Mar 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026 •
edited by openshift-ci bot
Loading

@DavidHurta: This pull request references OTA-1764 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2026
@DavidHurta
cvo: Add optional tls scanner presubmit job
0d3be70 
A failing test of the tls-scanner-run step [1] does not
fail the whole job [2]. At least, as of the moment.
Thus, make the job optional. An always passing job has no significant value.

Thus, the job is intended to be used to verify TLS changes explicitly.
We'll depend on existing periodic testing and fix things
when a regression is reported, if not caught during merging.

Use an AWS cluster profile in combination with stronger compute nodes
to handle the tls-scanner-run step. The default node type fails to
schedule the needed pods by the step. The node type was chosen
based on other tls-scanner jobs in the openshift/release repository.

[1]: https://steps.ci.openshift.org/reference/tls-scanner-run
[2]: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/76044/rehearse-76044-pull-ci-openshift-cluster-version-operator-main-tls-scanner/2031796334276644864
@DavidHurta
Run make jobs
44c491a
@DavidHurta DavidHurta force-pushed the cvo-add-tls-scanner branch from a01df69 to 44c491a Compare March 17, 2026 01:50
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026 •
edited by openshift-ci bot
Loading

@DavidHurta: This pull request references OTA-1764 which is a valid jira issue.

Details

In response to this:

To be used to verify openshift/cluster-version-operator#1338 changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

[REHEARSALNOTIFIER]
@DavidHurta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-version-operator-main-tls-scanner openshift/cluster-version-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@DavidHurta
Copy link
Contributor Author

DavidHurta commented Mar 17, 2026

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-tls-scanner

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

[REHEARSALNOTIFIER]
@DavidHurta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-version-operator-main-tls-scanner openshift/cluster-version-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DavidHurta
Copy link
Contributor Author

DavidHurta commented Mar 17, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 17, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 2902922 into openshift:main Mar 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking Awaiting requested review from wking

1 more reviewer

@fao89 fao89 fao89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fao89 fao89

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidHurta @openshift-ci-robot @fao89