Skip to content

rosa-cora-agent: fix mypy path in lint test#74891

Open
eth1030 wants to merge 1 commit intoopenshift:mainfrom
eth1030:rosa-cora-agent
Open

rosa-cora-agent: fix mypy path in lint test#74891
eth1030 wants to merge 1 commit intoopenshift:mainfrom
eth1030:rosa-cora-agent

Conversation

@eth1030
Copy link

@eth1030 eth1030 commented Feb 13, 2026

Summary

This fixes mypy path in lint test for rosa-cora-agent to resolve test failure.

The lint test was failing with:
mypy: can't read file 'main.py': No such file or directory
The test was trying to run mypy on main.py, but this file doesn't exist in the repository. The code is organized in the rosa_cora_agent/ package directory.

Test Plan

The lint test passes

@openshift-ci openshift-ci bot requested review from abyrne55 and tiwillia February 13, 2026 20:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eth1030

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@eth1030: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-online-rosa-cora-agent-main-lint openshift-online/rosa-cora-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eth1030
Copy link
Author

eth1030 commented Feb 13, 2026

/pj-rehearse pull-ci-openshift-online-rosa-cora-agent-main-lint

@openshift-ci-robot
Copy link
Contributor

@eth1030: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@eth1030
Copy link
Author

eth1030 commented Feb 13, 2026

/pj-rehearse abort

@openshift-ci-robot
Copy link
Contributor

@eth1030: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@eth1030
Copy link
Author

eth1030 commented Feb 13, 2026

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@eth1030: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@eth1030: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-online/rosa-cora-agent/main/lint 9e35976 link unknown /pj-rehearse pull-ci-openshift-online-rosa-cora-agent-main-lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eth1030
Copy link
Author

eth1030 commented Feb 13, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@eth1030: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants