Skip to content

Conversation

@gaol
Copy link
Contributor

@gaol gaol commented Dec 24, 2025

Epic Issue: https://issues.redhat.com/browse/CNTRLPLANE-1622
CI Issue: https://issues.redhat.com/browse/CNTRLPLANE-2005

This PR aimss to add the auto tests for the autoscaling from/to zero feature on AWS platform

This PR tries:

  • Adds a cucushift-hypershift-extended-autoscaling-from-zero step to check 5 use cases about scaling up with workload and scaling down after workload deletion
  • Includes the step in cucushift-installer-rehearse-aws-ipi-ovn-hypershift workflow
  • Adds option on hypershift operator installation on aws
  • Adds job configs to versions 4.16+

Please NOTE:

  • 4.16, 4.17 does not support specifying autoscaller API flags, like ScaleUpOnly, so that case won't be executed on the versions.
  • 4.16 and 4.17 may take longer time than newer versions to scale down because the configs to the hosted cluster '.spec.autoscaling.scaledown' cannot be propagated to the autoscaler pod in CP.
  • The job config will try to execute extended tests long duration with additional filter: AutoScaling&. The filter will be added to the extended tests about the autoscaling in hypershift in another pr to the OTP.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gaol
Copy link
Contributor Author

gaol commented Dec 24, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14

@openshift-ci-robot
Copy link
Contributor

@gaol: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gaol gaol force-pushed the autoscaling_from_zero branch from a08241c to cd902b8 Compare December 25, 2025 07:12
@gaol
Copy link
Contributor Author

gaol commented Dec 25, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f28 periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14

@openshift-ci-robot
Copy link
Contributor

@gaol: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gaol gaol force-pushed the autoscaling_from_zero branch from cd902b8 to 8ba045d Compare December 26, 2025 03:40
@gaol
Copy link
Contributor Author

gaol commented Dec 26, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f28 periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14

@openshift-ci-robot
Copy link
Contributor

@gaol: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gaol gaol force-pushed the autoscaling_from_zero branch from 8ba045d to 530f774 Compare December 26, 2025 14:03
@gaol gaol marked this pull request as ready for review December 26, 2025 14:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2025
@gaol gaol changed the title Autoscaling from zero [CNTRLPLANE-1622] - Tests on API support for setting min-replicas=0 on NodePool CRs Dec 26, 2025
@gaol
Copy link
Contributor Author

gaol commented Dec 26, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f28 periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14

@openshift-ci-robot
Copy link
Contributor

@gaol: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gaol gaol force-pushed the autoscaling_from_zero branch from 530f774 to 7048b22 Compare December 27, 2025 01:39
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@gaol: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-4.20-upgrade-from-stable-4.19-azure-aks-hypershift-etcd-disk-encryption-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-aws-ipi-ovn-arm-mixarch-mto-hypershift-arm-guest-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-azure-aks-hypershift-byo-vnet-fips-guest-f14-longduration N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-ovn-hypershift-mgmt-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-arm-nodepool-guest-efs-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-guest-ext-oidc-tp-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-fips-guest-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-guest-ext-oidc-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-aws-ipi-ovn-hypershift-arm-nodepool-guest-efs-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-rollback-nightly-azure-aks-hypershift-byo-vnet-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-private-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-arm-nodepool-mgmt-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-rollback-nightly-aws-ipi-ovn-hypershift-inplace-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-azure-aks-hypershift-arm-nodepool-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-4.21-upgrade-from-stable-4.20-azure-aks-hypershift-registry-overrides-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-conformance-calico-private N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-ovn-hypershift-fips-guest-f60 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-azure-aks-hypershift-arm-nodepool-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-azure-aks-hypershift-byo-vnet-fips-mgmt-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-fips-guest-openldap-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-guest-disable-caps-f14 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-conformance-cilium-private N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-aws-ipi-ovn-hypershift-arm-nodepool-mgmt-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-4.21-upgrade-from-stable-4.20-azure-aks-hypershift-etcd-disk-encryption-replace-guest-f28 N/A periodic Registry content changed

A total of 255 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@gaol
Copy link
Contributor Author

gaol commented Dec 27, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f28 periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14

@openshift-ci-robot
Copy link
Contributor

@gaol: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@heliubj18
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gaol, heliubj18
Once this PR has been reviewed and has the lgtm label, please assign xingxingxia for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaol
Copy link
Contributor Author

gaol commented Dec 29, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f28 periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14

@openshift-ci-robot
Copy link
Contributor

@gaol: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 29, 2025

@gaol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 7048b22 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 7048b22 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14 7048b22 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-ovn-hypershift-mgmt-autoscaling-f14

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants