Skip to content

Add Fusion Access CNV integration tests#71891

Closed
amp-rh wants to merge 2 commits intoopenshift:masterfrom
amp-rh:fusion-access-cnv-rebased
Closed

Add Fusion Access CNV integration tests#71891
amp-rh wants to merge 2 commits intoopenshift:masterfrom
amp-rh:fusion-access-cnv-rebased

Conversation

@amp-rh
Copy link
Contributor

@amp-rh amp-rh commented Nov 26, 2025

Summary

Adds CNV (OpenShift Virtualization) integration tests for IBM Fusion Access storage to verify that storage can be successfully provisioned and utilized by virtual machines managed by CNV.

Related JIRA

Changes

New Step Registry Components

Chain:

  • interop-tests-fusion-access-cnv-test-chain - Orchestrates CNV integration testing

Steps (7 new):

Step Purpose
create-shared-filesystem Create IBM Storage Scale filesystem for CNV
configure-cnv-shared-storage Configure shared storage for CNV
test-cnv-shared-storage Verify CNV can use shared storage
test-vm-lifecycle VM create/start/stop/restart tests
test-vm-migration Live VM migration tests
test-vm-snapshots VM snapshot create/restore/delete tests
verify-shared-storage Verify shared storage integration

Test Configuration

  • RedHatQE-interop-testing-master__fusion-access-cnv-ocp4.20-lp-interop.yaml - OCP 4.20 CNV integration test

Script Quality

All scripts follow OCP CI best practices from PR #67409 review:

  • set -eux -o pipefail; shopt -s inherit_errexit
  • SECONDS variable for timing (not date +%s)
  • Proper error handling with fail-fast approach
  • OWNERS files as symlinks where appropriate

Test Workflow

  1. Deploy OpenShift cluster with bare-metal workers (c5n.metal)
  2. Install CNV operator
  3. Deploy Fusion Access and IBM Storage Scale
  4. Create shared filesystem for CNV
  5. Configure CNV to use Storage Scale storage
  6. Run VM lifecycle tests (create, start, stop, restart)
  7. Run VM migration tests (live migration)
  8. Run VM snapshot tests (create, restore, delete)
  9. Verify shared storage integration

Testing

  • Rehearsal run passes
  • CNV integration tests execute successfully

@amp-rh amp-rh marked this pull request as draft November 26, 2025 14:39
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2025
@openshift-ci openshift-ci bot requested review from dbasunag and etirta November 26, 2025 14:42
@amp-rh amp-rh force-pushed the fusion-access-cnv-rebased branch from 709cb62 to f2275b2 Compare November 26, 2025 15:37
@amp-rh
Copy link
Contributor Author

amp-rh commented Nov 26, 2025

/pj-rehearse pull-ci-RedHatQE-interop-testing-master-fusion-access-cnv-ocp4.20-lp-interop-cr-images

@openshift-ci-robot
Copy link
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@amp-rh
Copy link
Contributor Author

amp-rh commented Nov 26, 2025

/pj-rehearse list

@openshift-ci-robot
Copy link
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@amp-rh amp-rh force-pushed the fusion-access-cnv-rebased branch from f2275b2 to 2f2b2ff Compare November 26, 2025 17:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amp-rh
Once this PR has been reviewed and has the lgtm label, please assign jupierce for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amp-rh
Copy link
Contributor Author

amp-rh commented Nov 26, 2025

/pj-rehearse pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-cr-images pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-images pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-cr-images pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-images pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-operator-ocp4.20-lp-interop-images

@openshift-ci-robot
Copy link
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@amp-rh
Copy link
Contributor Author

amp-rh commented Nov 26, 2025

/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-operator-ocp4.20-lp-interop-ibm-fusion-access-operator-ipi-ocp420

@openshift-ci-robot
Copy link
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2025
…mponent Readiness support

This commit adds comprehensive IBM Fusion Access Operator integration tests
for OpenShift 4.20 and 4.21, including CNV (OpenShift Virtualization)
integration and Component Readiness support.

Changes include:
- Step registry: Added interop-tests/ibm-fusion-access/ with complete
  test infrastructure
- Config files: Added ibm-fusion-access-operator and ibm-fusion-access-cnv
  test configurations for OCP 4.20 and 4.21
- Component Readiness: Added -cr variants for CI analysis
- Environment setup chain: Namespaces, operators, and IBM Storage Scale
- EBS integration chain: EBS-backed filesystem testing
- CNV test chain: OpenShift Virtualization integration tests
- Documentation: Complete guides and cursor rules for IBM Fusion Access
@amp-rh amp-rh force-pushed the fusion-access-cnv-rebased branch from 2f2b2ff to 8700926 Compare December 1, 2025 14:46
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@amp-rh
Copy link
Contributor Author

amp-rh commented Dec 1, 2025

/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-ibm-fusion-access-cnv-ipi-ocp420

@openshift-ci-robot
Copy link
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

… objects

The IBM Storage Scale Filesystem CRD expects the 'disks' field to contain
an array of strings (LocalDisk resource names), not objects with devicePath.

Changes:
- Create LocalDisk resources before Filesystem creation
- Reference LocalDisk names as strings in Filesystem spec
- Follow patterns from ibm-fusion-access create-local-disks step
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@amp-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-cr-images RedHatQE/interop-testing presubmit Presubmit changed
pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-images RedHatQE/interop-testing presubmit Presubmit changed
pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-cr-images RedHatQE/interop-testing presubmit Presubmit changed
pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-images RedHatQE/interop-testing presubmit Presubmit changed
pull-ci-RedHatQE-interop-testing-master-ibm-fusion-access-operator-ocp4.20-lp-interop-images RedHatQE/interop-testing presubmit Presubmit changed
periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-operator-ocp4.20-lp-interop-ibm-fusion-access-operator-ipi-ocp420 N/A periodic Periodic changed
periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-cr-ibm-fusion-access-cnv-cr-ocp420 N/A periodic Periodic changed
periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-ibm-fusion-access-cnv-ipi-ocp420 N/A periodic Periodic changed
periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-cr-ibm-fusion-access-cnv-cr-ocp421 N/A periodic Periodic changed
periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-ibm-fusion-access-cnv-ipi-ocp421 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor Author

@amp-rh amp-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-ibm-fusion-access-cnv-ipi-ocp421

@amp-rh
Copy link
Contributor Author

amp-rh commented Dec 3, 2025

/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-ibm-fusion-access-cnv-ipi-ocp421

@openshift-ci-robot
Copy link
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

@amp-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-operator-ocp4.20-lp-interop-ibm-fusion-access-operator-ipi-ocp420 2f2b2ff link unknown /pj-rehearse periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-operator-ocp4.20-lp-interop-ibm-fusion-access-operator-ipi-ocp420
ci/rehearse/periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-ibm-fusion-access-cnv-ipi-ocp420 8700926 link unknown /pj-rehearse periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.20-lp-interop-ibm-fusion-access-cnv-ipi-ocp420
ci/rehearse/periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-ibm-fusion-access-cnv-ipi-ocp421 2647ebe link unknown /pj-rehearse periodic-ci-RedHatQE-interop-testing-master-ibm-fusion-access-cnv-ocp4.21-lp-interop-ibm-fusion-access-cnv-ipi-ocp421

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amp-rh
Copy link
Contributor Author

amp-rh commented Dec 8, 2025

closing in favor of #72018

@amp-rh amp-rh closed this Dec 8, 2025
@amp-rh amp-rh deleted the fusion-access-cnv-rebased branch December 8, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants