OCPERT-239: Add migrated image consistency check #820

tomasdavidorg · 2025-12-04T09:55:09Z

https://issues.redhat.com/browse/OCPERT-239

openshift-ci · 2025-12-04T09:55:13Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-12-04T09:55:13Z

@tomasdavidorg: This pull request references OCPERT-239 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This is just a draft.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-12-04T09:55:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tomasdavidorg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-12-18T07:28:13Z

@tomasdavidorg: This pull request references OCPERT-239 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/OCPERT-239

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-12-18T07:28:32Z

@tomasdavidorg: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

https://issues.redhat.com/browse/OCPERT-239

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tomasdavidorg · 2025-12-18T07:33:02Z

oar/image_consistency_check/checker.py

+                # FIXME: If multiple images are found, should we fail the check?
+                logger.error(f"Multiple images found in Red Hat catalog. Please check manually.")
+                return False


Need to figure out how to recognize if the image is the correct one.

I don't think this is error case. even multiple items found, it means the image is already shipped.

So should I just pass if resp_data["total"] >= 1. I didn't find any example where there are more found items. I don't know how to recognize if one of the items is the correct one.

+1, we can add some trace logs from resp payload, like

curl -s "https://catalog.redhat.com/api/containers/v1/images?filter=image_id==sha256:45041834fa4fee1fed5415cee69f9723d50890a9685605f9b750635d8b1b01dd" | jq '.data[].repositories[]|.registry+"/"+.repository' "registry.access.redhat.com/openshift4/ose-vsphere-problem-detector-rhel9"

Logging added.

openshift-ci-robot · 2025-12-18T07:33:48Z

@tomasdavidorg: This pull request references OCPERT-239 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/OCPERT-239

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rioliu-rh · 2025-12-18T08:57:24Z

oar/image_consistency_check/checker.py

+        for shipment_pullspec in self.shipment_image_pullspecs:
+            if self.all_image_metadata[payload_pullspec].has_same_name(self.all_image_metadata[shipment_pullspec]):
+                has_same_name = True
+                logger.info(f"Found an image with the same name but different identifier. Please check manually.")


Is this a valid case? even name is same, but digest is not, they're not same image

No. See the line 136-138.
The method _find_images_with_same_name is just for investigation purposes. If there is image with same name but different identificators, it will debug log detais.

It is taken from the previous implementation. https://gitlab.cee.redhat.com/aosqe/openshift-misc/-/blob/master/jenkins/v4-image-test/errata_test/errata_test.py?ref_type=heads#L97-L127

debugging purpose is ok.

Marking as resolved.

tomasdavidorg · 2025-12-19T08:04:33Z

/retest

openshift-ci · 2025-12-19T08:14:38Z

@tomasdavidorg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	`7e42d2a`	link	true	`/test images`
ci/prow/oar-check	`7e42d2a`	link	false	`/test oar-check`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tomasdavidorg · 2025-12-19T08:20:56Z

https://github.com/openshift-eng/art-tools changed structure of project. Looking.

tomasdavidorg added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2025

OCPERT-239 Add migrated image consistency check

5b3cc61

tomasdavidorg force-pushed the OCPERT-239 branch from 36a17d1 to 5b3cc61 Compare December 18, 2025 07:26

tomasdavidorg changed the title ~~OCPERT-239: DRAFT migrate image consistency check~~ OCPERT-239 Add migrated image consistency check Dec 18, 2025

tomasdavidorg marked this pull request as ready for review December 18, 2025 07:28

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2025

openshift-ci bot requested review from LuboTerifaj and rioliu-rh December 18, 2025 07:29

tomasdavidorg commented Dec 18, 2025

View reviewed changes

tomasdavidorg changed the title ~~OCPERT-239 Add migrated image consistency check~~ OCPERT-239: Add migrated image consistency check Dec 18, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2025

Fix naming

2d79d93

rioliu-rh reviewed Dec 18, 2025

View reviewed changes

tomasdavidorg added 2 commits December 18, 2025 10:44

Fix doc

e2d6eec

Allow more images found

7e42d2a

OCPERT-239: Add migrated image consistency check #820

Are you sure you want to change the base?

OCPERT-239: Add migrated image consistency check #820

Uh oh!

Conversation

tomasdavidorg commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Dec 4, 2025

Uh oh!

openshift-ci-robot commented Dec 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Dec 4, 2025

Uh oh!

openshift-ci-robot commented Dec 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Dec 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomasdavidorg Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomasdavidorg commented Dec 19, 2025

Uh oh!

openshift-ci bot commented Dec 19, 2025

Uh oh!

tomasdavidorg commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tomasdavidorg commented Dec 4, 2025 •

edited

Loading

openshift-ci-robot commented Dec 4, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 18, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 18, 2025 •

edited by openshift-ci bot

Loading

tomasdavidorg Dec 18, 2025 •

edited

Loading