Skip to content

Conversation

@jhuttana
Copy link
Contributor

Adds a new Claude Code slash command that provides an interactive way to
list and filter pull requests in the repository using the GitHub CLI.

Features:

  • List open/closed/merged/all PRs
  • Filter by author, assignee, or labels
  • Customize result limit
  • Display PR number, title, author, status, labels, and last updated

The command wraps 'gh pr list' with a user-friendly interface, making it
easier to review PRs during development workflows.

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rioliu-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhuttana
Copy link
Contributor Author

/assign @rioliu-rh @tomasdavidorg

@tomasdavidorg
Copy link
Contributor

tomasdavidorg commented Nov 13, 2025

I'm not sure this brings any additional value. It's essentially another layer that wraps gh pr list, which already supports all these filters out of the
box:

gh pr list --author @me --label bug --limit 10

Our existing /pr:approve and /pr:lgtm commands make sense because they add automation (posting comments), but this just duplicates functionality that's already readily available.

@rioliu-rh rioliu-rh closed this Nov 13, 2025
@rioliu-rh rioliu-rh reopened this Nov 13, 2025
@rioliu-rh
Copy link
Contributor

TBH, cc can recognize gh cli and collaborate with it perfectly. I don't think we need this wrapper cmd

@jhuttana jhuttana closed this Nov 13, 2025
@jhuttana
Copy link
Contributor Author

@tomasdavidorg and @rioliu-rh : Just a finding, looks like even the current PR commands (/pr:lgtm and /pr:approve) are just thin wrappers around "gh pr comment", which doesn't add much value since users can just run gh pr comment --body "/lgtm" directly.

@jhuttana jhuttana reopened this Nov 13, 2025
@rioliu-rh
Copy link
Contributor

rioliu-rh commented Nov 13, 2025

@tomasdavidorg and @rioliu-rh : Just a finding, looks like even the current PR commands (/pr:lgtm and /pr:approve) are just thin wrappers around "gh pr comment", which doesn't add much value since users can just run gh pr comment --body "/lgtm" directly.

because AI agent does not know how to use our CI plugin. it only can add label for a PR with option --add-label. e.g. gh pr edit 123 --add-label lgtm, but we need to add label via comment instead. the commands can be used with builtin cmd /review pr# (if the pr# is not provided, it can help us list all the opened PRs ), if the code review looks good, then trigger custom slash cmd /pr:lgtm or /pr:approve directly to approve the PR, it's convenient to make PR review process more efficient

@openshift-ci
Copy link

openshift-ci bot commented Nov 13, 2025

@jhuttana: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants